From owner-cvs-all  Fri Jan  8 09:21:40 1999
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id JAA22711
          for cvs-all-outgoing; Fri, 8 Jan 1999 09:21:40 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.54])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA22683;
          Fri, 8 Jan 1999 09:21:27 -0800 (PST)
          (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.9.1/8.9.1) id JAA91509;
	Fri, 8 Jan 1999 09:28:21 -0800 (PST)
	(envelope-from sgk)
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
Message-Id: <199901081728.JAA91509@troutmask.apl.washington.edu>
Subject: Re: cvs commit: src/gnu/usr.bin/binutils/strip Makefile
In-Reply-To: <199901081127.WAA29679@godzilla.zeta.org.au> from Bruce Evans at "Jan 8, 1999 10:27:20 pm"
To: bde@zeta.org.au (Bruce Evans)
Date: Fri, 8 Jan 1999 09:28:21 -0800 (PST)
Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, n_hibma@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL43 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

According to Bruce Evans:
> >  Modified files:
> >    gnu/usr.bin/binutils/strip Makefile 
> >  Log:
> >  Ignore return value for strip. Avoids make world going pop
> >  because of
> >  
> >  strip maybe_stripped
> >  strip: maybe_stripped: File format not recognized
> >  *** Error code 1
> >  
> >  in I/usr/src/gnu/usr.bin/binutils/strip
> 
> Hmm, usr.bin/strip already has this breakage (ignoring an error).
> Possible correct fixes:
> 
> - use `install -C' to get an atomic install and remove all the maybe_stripped
>   complications.  (Someday, `install' should always be atomic.)
> - remove "." from $PATH.
> - abort `make world' if "." is in $PATH.
> 

I agree with Bruce that ignoring the error isn't the correct
solution.  Aborting `make world' if "." is in $PATH should
be the default action with an admonishment of the person trying
to run `make world'.  God only knows (and maybe Bruce) what kind
of trojan horses that a malicious user can embedded within a
`make world'.

-- 
Steve

finger kargl@troutmask.apl.washington.edu
http://troutmask.apl.washington.edu/~clesceri/kargl.html

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message