From owner-freebsd-current@FreeBSD.ORG Thu Nov 12 01:46:19 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28663106568F; Thu, 12 Nov 2009 01:46:19 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 57C218FC27; Thu, 12 Nov 2009 01:46:18 +0000 (UTC) Received: by bwz5 with SMTP id 5so1810384bwz.3 for ; Wed, 11 Nov 2009 17:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=ip37CHjbK9R4gZcWH8cFioAxa+03Mul9u5XcHI7lBXU=; b=vU7/SfQMNF+UQYMURTCXYARMiPBrVcMCFHQNQUaXSWv5cJtzxoYInhyUz0Kki+sPoi la9Duhg9WGRauuN6mp7+dE+ZGXMUgK6vc5UePXLU7QXnlbalI6iorOFf8O/dDMvcKa3C Qh8+K3S6RJLzOH5bzN/3R0K6a2/whe5S54Hic= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=W54iz7tBudDKIx6E8/7P1wD3lv7ESf2bpj9/Y19XenN6q7vm23JEVabAFAlU0rnBMY lLqCHaKYUDvDsW1ARiYAucd5AydJZqfjvRlSI0leUG+ot4K3Sknqs/VzvB/5/npIbgjj EaRtV03p1ckPMDNCU7wdf79zqh+8mK/1iAGds= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.223.22.4 with SMTP id l4mr323319fab.37.1257990375056; Wed, 11 Nov 2009 17:46:15 -0800 (PST) In-Reply-To: <4AFAEE89.3020009@scsiguy.com> References: <3bbf2fe10911060643g60079e31y7679b32dac670fd8@mail.gmail.com> <4AFAEE89.3020009@scsiguy.com> Date: Thu, 12 Nov 2009 02:46:14 +0100 X-Google-Sender-Auth: ba778fd8e8c626c7 Message-ID: <3bbf2fe10911111746g48c8fb82r74744dffedf49758@mail.gmail.com> From: Attilio Rao To: "Justin T. Gibbs" Content-Type: text/plain; charset=UTF-8 Cc: gibbs@freebsd.org, freebsd-current@freebsd.org, Scott Long , Ed Maste Subject: Re: [PATCH] Adding sysctl for errors statistics to ahd(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2009 01:46:19 -0000 2009/11/11 Justin T. Gibbs : > On 11/6/2009 7:43 AM, Attilio Rao wrote: >> This patch introduces some mechanisms for collecting informations on >> errors frequency and debugging (and relative sysctls for printing them >> out) for the ahd(4) driver: >> http://www.freebsd.org/~attilio/Sandvine/STABLE_8/ahd/ahd-current2.diff >> >> The usage of array for sysctls is a bit too paranoid but it allows for >> further extendibility of the code and doesn't loose of cleaness. >> This code has been contributed back by Sandvine Incorporated with some >> cleanups. >> Please review. >> >> Thanks, >> Attilio > > In general, I think the patch is fine. It violates the existing style > of the driver in some places (e.g. the aic7xxx drivers wrap function > arguments to the opening '(' not to a 4 space indent), which should > probably be addressed so the code remains consistent. Sorry, I cannot find where these existing style breakage happens, could you be a bit more precise? (I just found an un-sorted header introduction in aic79xx.h that I will fix). Anyways, your idea about a generalized interface in newbus for handling that is not bad and as long as I'm planning some works in this area I can add this item to the TODO list. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein