From owner-freebsd-chromium@FreeBSD.ORG Sun Mar 27 10:18:31 2011 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CE30106575C for ; Sun, 27 Mar 2011 10:18:31 +0000 (UTC) (envelope-from geo.liaskos@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id CD1DB8FC25 for ; Sun, 27 Mar 2011 10:18:30 +0000 (UTC) Received: by qwc9 with SMTP id 9so1557796qwc.13 for ; Sun, 27 Mar 2011 03:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=H7M2f85kon70N4L30golFdPhDuzP9hszaoC9ErVF9uE=; b=OWTChZIC524rXdYlupaur69Ipl8AH9xSBkoLBfp+k3U44Xx3DGUOou+vuilD7gXjwd eR7cUiuE1uO/0ztREA4d14ZViA8UiXE7RDdkxnk5fEZz/0sa/3ij5NVZpMqjM5IyhpW8 7jwFU9U7Koo4VBU1+sXedNr7AyXa8Bu867ju0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=abjrpMl7u8MhlBc8N8I1csRrWehJti3vYA2Aj5OJ96BqNp7Ps43IBZugecw9uXgTWw Q4HMSXMLy1AW72immpijf60saSQYJFeATOGGclCA7z1wpzwq2q5EaPVfqirlombeDKB1 krP4VrNRjnnzYW9QsFWC411FAxGzaJ6Rhb6ew= MIME-Version: 1.0 Received: by 10.224.184.3 with SMTP id ci3mr2285822qab.50.1301221110116; Sun, 27 Mar 2011 03:18:30 -0700 (PDT) Received: by 10.229.188.141 with HTTP; Sun, 27 Mar 2011 03:18:30 -0700 (PDT) In-Reply-To: References: Date: Sun, 27 Mar 2011 13:18:30 +0300 Message-ID: From: George Liaskos To: Evan Martin Content-Type: text/plain; charset=UTF-8 Cc: freebsd-chromium@freebsd.org, "Y. A." Subject: Re: fixes for Makefile pkg-plist and build-in ffmpeg X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2011 10:18:31 -0000 On Sun, Mar 27, 2011 at 11:28 AM, Evan Martin wrote: > Can you send the ffmpeg patch upstream? > > (Does ffmpeg/libavutil as upstream from Chrome build on FreeBSD?) There's an #if HAVE_MALLOC_H, malloc.h shouldn't be included. Do we really need the following patches? I compiled chrome without them, they include #define HAVE_MALLOC_H 0 which obviously doesn't affect anything. patch-third_party__ffmpeg__config__Chrome__freebsd__ia32__config.h patch-third_party__ffmpeg__config__Chrome__freebsd__x64__config.h patch-third_party__ffmpeg__config__Chromium__freebsd__ia32__config.h patch-third_party__ffmpeg__config__Chromium__freebsd__x64__config.h patch-third_party__ffmpeg__ffmpeg.gyp This should probably go and just add use_system_yasm=1 at GYP_DEFINES.