From owner-freebsd-stable@FreeBSD.ORG Thu May 1 05:55:55 2014 Return-Path: Delivered-To: stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0203DF4D; Thu, 1 May 2014 05:55:55 +0000 (UTC) Received: from gw.catspoiler.org (gw.catspoiler.org [75.1.14.242]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D9F961039; Thu, 1 May 2014 05:55:54 +0000 (UTC) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id s415tfL6034493; Wed, 30 Apr 2014 22:55:45 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201405010555.s415tfL6034493@gw.catspoiler.org> Date: Wed, 30 Apr 2014 22:55:41 -0700 (PDT) From: Don Lewis Subject: Re: Thinkpad R60 hangs when booting recent 8.4-STABLE To: jhb@FreeBSD.org In-Reply-To: <201404301738.26632.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Cc: stable@FreeBSD.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2014 05:55:55 -0000 On 30 Apr, John Baldwin wrote: > Are you up for doing some printf sleuthing? There are two odd things that I > see so far: > > 1) the base address of 0. The question here is if pci_add_map() in > sys/dev/pci/pci.c decides to set start to 0 explicitly, or if it happens > further up the callchain (should be bus_alloc_resource calls in > sys/dev/acpica/acpi_pcib_acpi.c, sys/x86/x86/nexus.c and then in the > rman code itself in sys/kern/subr_rman.c) > > 2) The 'reserved' printfs during boot probe. Those come from a printf in > pci_alloc_resource() in sys/dev/pci/pci.c. However, that should not be called > until a driver attaches to a device and calls bus_alloc_resource(). It should > not be called from pci_add_child() as it seems to be now. The call graph for the four earlier ones that you previously pointed out (not hostb0) is: pci_add_child() pci_add_resources() *_early_takeover() [I suspect] bus_alloc_resource_any() pci_alloc_resource() These are the three system uhci controllers and the system ehci controller, which apparently pass this test: pci_get_class(dev) == PCIC_SERIALBUS && pci_get_subclass(dev) == PCIS_SERIALBUS_USB