From owner-svn-ports-all@freebsd.org Mon Apr 30 07:35:24 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 202D0FC6938; Mon, 30 Apr 2018 07:35:24 +0000 (UTC) (envelope-from mat@atuin.in.mat.cc) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "prod2.absolight.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4BB377D9F; Mon, 30 Apr 2018 07:35:23 +0000 (UTC) (envelope-from mat@atuin.in.mat.cc) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 0E800BDD2D; Mon, 30 Apr 2018 09:35:22 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id C1428BDD25; Mon, 30 Apr 2018 09:35:21 +0200 (CEST) Received: by atuin.in.mat.cc (Postfix, from userid 501) id 5A12AB17AF89; Mon, 30 Apr 2018 09:35:20 +0200 (CEST) Date: Mon, 30 Apr 2018 09:35:20 +0200 From: Mathieu Arnold To: Eitan Adler , Jan Beich , Bernard Spil , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468626 - head/security/libressl Message-ID: <20180430073520.4lerfledm5e35eiz@atuin.in.mat.cc> References: <201804291237.w3TCbbjB046542@repo.freebsd.org> <4lju-t6cm-wny@FreeBSD.org> <20180429175337.GK72744@graf.pompo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vsyaqisw5bvvjtgz" Content-Disposition: inline In-Reply-To: <20180429175337.GK72744@graf.pompo.net> User-Agent: NeoMutt/20170912 (1.9.0) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 07:35:24 -0000 --vsyaqisw5bvvjtgz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 29, 2018 at 05:53:37PM +0000, Thierry Thomas wrote: > Le dim. 29 avr. 18 =E0 19:36:51 +0200, Eitan Adler > =E9crivait=A0: >=20 > > >> security/libressl: Force linking libthr > > >> > > >> - Fixes problems with loading private ssh keys > > > [...] > > >> +LDFLAGS+=3D -lthr > > > > > > Better use -lpthread in case user have different POSIX threads implem= entation. > > > Probably only affects downstream as FreeBSD dropped libkse, libc_r ye= ars ago. > >=20 > > Further nit: -pthread not -lpthread. The primary difference is some > > preprocessor flags such as _REENTRANT and __USE_REENTRANT 1. >=20 > We used to have a PTHREAD_LIBS variable (along with PTHREAD_CFLAGS); why > did they disappear? Because for about a decade, they only contained -pthread (and nothing), so keeping them was deemed useless. --=20 Mathieu Arnold --vsyaqisw5bvvjtgz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJa5sc4XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IMe8P/iXpvO84ZvhYwBGObNqoIHB+ oQFl14XFA7GZvLBraaHVv9i+VD4/g2/wblNKopXi4NXEPpZhqwDe0P4Dm4Fm5Klb BhqLVnXVE2ANiWVHEOn+ryJBIDSmPI0rCvU6tlztlfCyitmYVpxAyYu3dWfVCUrN lp/yuEezkL5k3ul7JVulNUvaUlSg65r8Bs0sza9Zf8Mv5oQI+L5rtSduRW469o+4 cf5PJspTRfvqB3XP+dHTapsmnZM4GdILNR/r2dnCDb0ahaELG2RWS1K/trFT15bE vrnLkGTL4tq5l28sIb5Ec569IGDQPRmM98jXy6PihsQfzj7yLSD8Ii/3NW5mvite mlFyEXUH7sxfCSEY0fpB1FgucVrlhPHjY/belKKuMWeH5QNHc0cq0ZwSdGJfcdsF XelIzt1lPkTdSjp6moo4kTjyQzwa6Nhy5OT4c7k4UAUSAS3OBuVVS3b7ZUvJ5bIZ yvdshbd4XyWdqsPFk6BquFAvWUK7W/zrnnAR4sXdiUafIneY/QUwVy5XtFvoO11d gB6eslo3cenjTXpaHrKtirshvzRWj/ZMCMeFxuP7depbA6sV+PYHe05mjiCZggX+ Dpmx2qiHocOOJ7H3B7DWacd9iwCw7GnFputabE4aNwxKxeSXQ+iKmR8yf3EKNibx 7x2hqf5kuZ2n9h88yH+/ =5N/Y -----END PGP SIGNATURE----- --vsyaqisw5bvvjtgz--