From owner-freebsd-net@FreeBSD.ORG  Sun Dec  6 08:34:40 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B300106566C
	for <freebsd-net@freebsd.org>; Sun,  6 Dec 2009 08:34:40 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E9778FC08
	for <freebsd-net@freebsd.org>; Sun,  6 Dec 2009 08:34:39 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id DD3BC730DA; Sun,  6 Dec 2009 09:42:56 +0100 (CET)
Date: Sun, 6 Dec 2009 09:42:56 +0100
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Julian Elischer <julian@elischer.org>
Message-ID: <20091206084256.GB40585@onelab2.iet.unipi.it>
References: <933fa9790912040047k64aa11a7s736688e7382725ad@mail.gmail.com>
	<933fa9790912051124x77f33878tfe588c0cbdb1fe4@mail.gmail.com>
	<4B1B4728.2050308@elischer.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B1B4728.2050308@elischer.org>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-net@freebsd.org, Gleb Smirnoff <glebius@glebius.int.ru>,
	Lytochkin Boris <lytboris@gmail.com>
Subject: Re: FreeBSD 8: ipfw fwd and pf route-to broken?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2009 08:34:40 -0000

On Sat, Dec 05, 2009 at 09:54:48PM -0800, Julian Elischer wrote:
> Lytochkin Boris wrote:
> >Hi!
> >
> >sbin/ipfw in RELENG_8 do not set sin_len in fwd rule, so sockaddr_in
> >from ipfw is sucked into rtalloc1_fib() at last with zero length and
> >is routed to lo0 instead of correct interface.
> >Returning sin_len into sbin/ipfw resolves issue.
> >
> >sin_len setting was removed in revision 1.146 by luigi.
> >
> >What is correct solution? Return sin_len setting into sbin/ipfw or
> >something else?

if you have tested that putting back sin_len fixes the problem
then it should definitely go in again.
interesting bug, i will put it a fix as soon as i have a chance

thanks
luigi