From owner-cvs-all@FreeBSD.ORG Tue Feb 12 23:05:29 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 899A916A421; Tue, 12 Feb 2008 23:05:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id AE2E113C4CE; Tue, 12 Feb 2008 23:05:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 231733404-1834499 for multiple; Tue, 12 Feb 2008 18:04:39 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m1CN5Pcs065762; Tue, 12 Feb 2008 18:05:25 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Maxim Sobolev Date: Tue, 12 Feb 2008 17:14:57 -0500 User-Agent: KMail/1.9.7 References: <200802122055.m1CKt4oL044057@repoman.freebsd.org> <47B212C2.2040005@FreeBSD.org> In-Reply-To: <47B212C2.2040005@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-u" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802121714.57708.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 12 Feb 2008 18:05:25 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5794/Tue Feb 12 15:49:27 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Christian S.J. Peron" , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys ipc.h shm.h src/sys/kern sysv_shm.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2008 23:05:29 -0000 On Tuesday 12 February 2008 04:42:26 pm Maxim Sobolev wrote: > Christian S.J. Peron wrote: > > csjp 2008-02-12 20:55:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys ipc.h shm.h > > sys/kern sysv_shm.c > > Log: > > Make sure we restrict Linux only IPC calls from being executed > > through the FreeBSD ABI. IPC_INFO, SHM_INFO, SHM_STAT were added > > specifically for Linux binary support. They are not documented > > as being a part of the FreeBSD ABI, also, the structures necessary > > for them have been hidden away from the users for a long time. > > > > Also, the Linux ABI layer uses it's own structures to populate the > > responses back to the user to ensure that the ABI is consistent. > > > > I think there is a bit more separation work that needs to happen. > > > > Reviewed by: jhb > > Discussed with: jhb > > Discussed on: freebsd-arch@ (very briefly) > > MFC after: 1 month > > Just curious why not make those functions available via FreeBSD API > instead by properly advertising them in the documentation? From my > completely ignorant point of view it should make it easier to port a > software that has been created on Linux, which is always a Good Thing[tm]. The only thing Linux uses it for is to implement ipcs(8). Our current ipcs(8) still grubs around in kvm directly. I think a good idea would be to look at enabling these after the SYSV IPC ABI has settled from all the upcoming changes and use them (or sysctls) to replace the use of kvm on live kernels for ipcs and ipcrm. -- John Baldwin