From owner-freebsd-acpi@FreeBSD.ORG Thu Jul 15 19:19:25 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC98416A4CE; Thu, 15 Jul 2004 19:19:25 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69DE543D46; Thu, 15 Jul 2004 19:19:25 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-63-195-111-154.dsl.snfc21.pacbell.net [63.195.111.154]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i6FJJOrb011151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 15 Jul 2004 12:19:24 -0700 Message-ID: <40F6D871.1090207@root.org> Date: Thu, 15 Jul 2004 12:18:09 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 Followup-To: acpi@freebsd.org To: John Baldwin References: <200406231508.i5NF8egh052377@repoman.freebsd.org> <200406231122.04154.jhb@FreeBSD.org> <20040715161403.GA741@laptop.6bone.nl> <200407151418.01839.jhb@FreeBSD.org> In-Reply-To: <200407151418.01839.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 15 Jul 2004 19:21:47 +0000 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2004 19:19:26 -0000 [Followups to the acpi list] John Baldwin wrote: > On Thursday 15 July 2004 12:14 pm, Mark Santcroos wrote: >>You forgot to mention that this commit breaks acpi_video ;-) >> >>The fact that "\_SB_.PCI0.AGP_.VID_" now no longer is "unknown", means that >>it is not probed anymore. >> >>The result of that is that acpi_video can't attach anymore of course. > > That's because acpi_video is really a PCI driver. :) The device it is > attaching too is a PCI device, not an ACPI device, hence the confusion. I > have some early work started on a vga_pci driver that would have child > devices like acpi_video0, drm0, agp0 (for Intel onboard graphics), and dpms0. I ran into this fundamental mismatch in building the infrastructure for the floppy attachment. You might have an ACPI handle namespace like this: _SB PCI0 LPC FDC0 FDD0 FOOBAR USB0 With a FreeBSD device hierarchy of: acpi0 fdc0 fd0 foobar pcib0 pci0 uhci0 Currently, we start with a flat device space when probing children: acpi0 pci0 isa0 fdc0 fd0 foobar uhci0 And then let each bus driver rework its children. PCI updates its child handles (USB0), deleting the initial device and adding a new one. FDC does the same thing. John is right in that acpi_video needs to attach to video_pci and not acpi directly. The new acpi_scan_children method should help do this without creating binary dependencies between drivers. -- -Nate