From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 31 06:45:04 2005 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7476816A4CE; Thu, 31 Mar 2005 06:45:04 +0000 (GMT) Received: from gen129.n001.c02.escapebox.net (gen129.n001.c02.escapebox.net [213.73.91.129]) by mx1.FreeBSD.org (Postfix) with ESMTP id B41BE43D31; Thu, 31 Mar 2005 06:45:03 +0000 (GMT) (envelope-from gemini@geminix.org) Message-ID: <424B9C67.6090201@geminix.org> Date: Thu, 31 Mar 2005 08:44:55 +0200 From: Uwe Doering Organization: Private UNIX Site User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.6) Gecko/20050326 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joshua Coombs References: <200503301440.j2UEe7s9078005@freefall.freebsd.org> In-Reply-To: <200503301440.j2UEe7s9078005@freefall.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Received: from gemini by geminix.org with asmtp (TLSv1:AES256-SHA:256) (Exim 3.36 #1) id 1DGtQH-000Iyw-00; Thu, 31 Mar 2005 08:44:57 +0200 cc: freebsd-bugs@FreeBSD.org cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/79339: [patch] Kernel time code sync with improvements from DragonFly X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2005 06:45:04 -0000 Joshua Coombs wrote: > The following reply was made to PR kern/79339; it has been noted by GNATS. > > From: "Joshua Coombs" > To: , > "Joshua Coombs" > Cc: > Subject: Re: kern/79339: [patch] Kernel time code sync with improvements from DragonFly > Date: Wed, 30 Mar 2005 09:33:59 -0500 > > Testing with wakeup_latency.c on a 5.3-Rel box shows the same symptom set. > I've not yet tested the proposed fix on 5-x. I will try dupilcating this > issue on 6-current as well to nail down the problem scope. Please also look at what's actually in DragonFly's CVS repository. Your PR is based on the original patch, while the code in DragonFly is more sophisticated. Namely, tvtohz() was split into two functions, tvtohz_low() and tvtohz_high(), which replace the original function depending on the context tvtohz() appears in. From this I conclude that the original patch is insufficient (likely to break parts of the kernel), and that integrating this improvement into FreeBSD might not be as easy and straightforward as it appears to be at first glance. On the other hand, with some effort it ought to be doable. Uwe -- Uwe Doering | EscapeBox - Managed On-Demand UNIX Servers gemini@geminix.org | http://www.escapebox.net