From owner-freebsd-stable@FreeBSD.ORG Tue Jan 26 20:12:28 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C77A01065672; Tue, 26 Jan 2010 20:12:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 8334F8FC14; Tue, 26 Jan 2010 20:12:28 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 143D346B4C; Tue, 26 Jan 2010 15:12:28 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 50D178A021; Tue, 26 Jan 2010 15:12:27 -0500 (EST) From: John Baldwin To: Marius Strobl Date: Tue, 26 Jan 2010 15:10:59 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.2-CBSD-20100120; KDE/4.3.1; amd64; ; ) References: <20100126073336.GA1955@server.vk2pj.dyndns.org> <201001260946.44977.jhb@freebsd.org> <20100126183756.GA40779@alchemy.franken.de> In-Reply-To: <20100126183756.GA40779@alchemy.franken.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201001261510.59667.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 26 Jan 2010 15:12:27 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: rmacklem@freebsd.org, dfr@freebsd.org, freebsd-stable@freebsd.org, Peter Jeremy Subject: Re: uma_zalloc_arg complaining about non-sleepable locks X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 20:12:29 -0000 On Tuesday 26 January 2010 1:37:56 pm Marius Strobl wrote: > On Tue, Jan 26, 2010 at 09:46:44AM -0500, John Baldwin wrote: > > On Tuesday 26 January 2010 2:33:37 am Peter Jeremy wrote: > > > I have just upgraded to 8-STABLE/amd64 from about 18 hours ago and am > > > now getting regular (the following pair of messages about every > > > minute) compaints as follows: > > > > > > kernel: uma_zalloc_arg: zone "mbuf" with the following non-sleepable locks held: > > > kernel: exclusive sleep mutex sp_lock (sp_lock) r = 0 (0xffffff000460bb00) locked @ /usr/src/sys/rpc/svc.c:1098 > > > kernel: KDB: stack backtrace: > > > kernel: db_trace_self_wrapper() at db_trace_self_wrapper+0x2a > > > kernel: _witness_debugger() at _witness_debugger+0x2c > > > kernel: witness_warn() at witness_warn+0x2c2 > > > kernel: uma_zalloc_arg() at uma_zalloc_arg+0x29d > > > kernel: nfs_realign() at nfs_realign+0x5f > > > kernel: fha_assign() at fha_assign+0x2d8 > > > kernel: svc_run_internal() at svc_run_internal+0x1ee > > > kernel: svc_thread_start() at svc_thread_start+0xb > > > kernel: fork_exit() at fork_exit+0x112 > > > kernel: fork_trampoline() at fork_trampoline+0xe > > > kernel: --- trap 0xc, rip = 0x80069e04c, rsp = 0x7fffffffe6d8, rbp = 0x5 --- > > > kernel: uma_zalloc_arg: zone "mbuf" with the following non-sleepable locks held: > > > kernel: exclusive sleep mutex sp_lock (sp_lock) r = 0 (0xffffff000460bb00) locked @ /usr/src/sys/rpc/svc.c:1098 > > > kernel: KDB: stack backtrace: > > > kernel: db_trace_self_wrapper() at db_trace_self_wrapper+0x2a > > > kernel: _witness_debugger() at _witness_debugger+0x2c > > > kernel: witness_warn() at witness_warn+0x2c2 > > > kernel: uma_zalloc_arg() at uma_zalloc_arg+0x29d > > > kernel: nfs_realign() at nfs_realign+0x5f > > > kernel: fha_assign() at fha_assign+0x2d8 > > > kernel: svc_run_internal() at svc_run_internal+0x1ee > > > kernel: svc_thread_start() at svc_thread_start+0xb > > > kernel: fork_exit() at fork_exit+0x112 > > > kernel: fork_trampoline() at fork_trampoline+0xe > > > kernel: --- trap 0xc, rip = 0x80069e04c, rsp = 0x7fffffffe6d8, rbp = 0x5 --- > > > > > > It looks like NFS is missing some lock/unlock pairs. Has anyone else > > > seen this? And does anyone have a fix? > > > > I suspect this was caused by the recent alignment fixes to NFS. I've cc'd > > Marius. > > > > Could you please give the following patch a try? > http://people.freebsd.org/~marius/fha_extract_info_realign2.diff > > It would also be great if one of the NFS gurus could have a look at > the whole issue. Unfortunately, I hadn't received a reply regarding > the original patch. Hmm, the old code was already using M_DONTWAIT, so now I don't see why you were getting the witness warning. -- John Baldwin