From owner-cvs-all  Wed Jan 24  0:33:34 2001
Delivered-To: cvs-all@freebsd.org
Received: from blizzard.sabbo.net (ns.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 35C0637B404; Wed, 24 Jan 2001 00:33:01 -0800 (PST)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f0O8Wr921119;
	Wed, 24 Jan 2001 10:32:56 +0200
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.1/8.9.3) with ESMTP id f0O8WhQ41014;
	Wed, 24 Jan 2001 10:32:43 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3A6E9326.51CA5EC0@FreeBSD.org>
Date: Wed, 24 Jan 2001 10:32:38 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.76 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: Jeremy Lea <reg@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/pkg_install/add extract.c main.c 
 src/usr.sbin/pkg_install/create create.h main.c perform.c pkg_create.1 
 src/usr.sbin/pkg_install/lib file.c plist.c
References: <200101221201.f0MC1tV27540@freefall.freebsd.org> <20010124000617.C63549@shale.csir.co.za>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Jeremy Lea wrote:

> Hi,
>
> On Mon, Jan 22, 2001 at 04:01:55AM -0800, Maxim Sobolev wrote:
> >   Modified files:
> >     usr.sbin/pkg_install/add extract.c main.c
> >     usr.sbin/pkg_install/create create.h main.c perform.c
> >                                 pkg_create.1
> >     usr.sbin/pkg_install/lib file.c plist.c
> >   Log:
> >   - Add ability to handle bzip2-compressed packages;
>
> The code in create/main.c never turns UseBzip2 = TRUE.  Which implies
> it was never tested, which also implies that the command line switch is
> redundant.

Oh, you are right, I'm sorry. I supposed that I fixed it in all my working
copies. And no, I tested how it works.

>  We can guess bzip2 compression from the suffix.  In fact we
> have to have a bzip2 suffix, else we can't guess how to extract it, so
> having a command line switch can only cause bad things to happen.

Not actually, if you are specifying package name witout trailing suffix
pkg_create will automatically add .tgz by default or .tbz2 if -y is specified.
See pkg_perform() finction for details.

> >   No response from:   -ports
>
> This should have read
>
> Approved by:    jkh
>
> He is the maintainer of this code, not -ports.  (Even if he never
> changes it or reviews patches :-( )

I CC'ed him as well, but did not hear anything back.

Thanks for taking a look at my changes.

-Maxim




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message