From owner-freebsd-geom@FreeBSD.ORG  Sun Feb  1 13:30:15 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 67A2116A4CE; Sun,  1 Feb 2004 13:30:15 -0800 (PST)
Received: from mailbox.univie.ac.at (mail.univie.ac.at [131.130.1.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4028843D48; Sun,  1 Feb 2004 13:30:04 -0800 (PST)
	(envelope-from l.ertl@univie.ac.at)
Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11])
	i11LTv37412572;	Sun, 1 Feb 2004 22:29:59 +0100
Date: Sun, 1 Feb 2004 22:29:54 +0100 (CET)
From: Lukas Ertl <l.ertl@univie.ac.at>
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
In-Reply-To: <30784.1075659981@critter.freebsd.dk>
Message-ID: <20040201222823.M616@korben.in.tern>
References: <30784.1075659981@critter.freebsd.dk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-DCC-ZID-Univie-Metrics: imap 4241; Body=3 Fuz1=3 Fuz2=3
cc: sos@freebsd.org
cc: freebsd-geom@freebsd.org
Subject: Re: Panic in g_disk_done() with atacontrol detach 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Feb 2004 21:30:15 -0000

On Sun, 1 Feb 2004, Poul-Henning Kamp wrote:

> In message <20040201190653.M613@korben.in.tern>, Lukas Ertl writes:
> >The problem obviously is that ad_detach() calls disk_destroy() which nulls
> >out the softc, and in g_disk_done() this softc is referenced again.
> >
> >The question is: is this an unsupported operation in the sense of "don't
> >do that"?  If yes, then "atacontrol detach" should probably refuse to do
> >the actual detach when there are I/O requests running, this would prevent
> >a lot of foot shooting.
>
> No, this should work.

Ok, but just commenting out the "gp->softc = NULL" statements apparently
aren't the way to go, cause then I end up in a panic somewhere in the
softupdate code...

Any hints how to properly do this?

regards,
le

-- 
Lukas Ertl                             eMail: l.ertl@univie.ac.at
UNIX Systemadministrator               Tel.:  (+43 1) 4277-14073
Vienna University Computer Center      Fax.:  (+43 1) 4277-9140
University of Vienna                   http://mailbox.univie.ac.at/~le/