From nobody Fri Sep 8 09:36:24 2023 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhrbF0JFZz4sGL0 for ; Fri, 8 Sep 2023 09:36:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhrbD4VF7z4DqB for ; Fri, 8 Sep 2023 09:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694165784; a=rsa-sha256; cv=none; b=Ld3Zu2ihBDDzhx/qv+UafMAfJlEgs9hCJws8eGe17N4Ih97LlWBguQntWWpJPEDQMWLAzS GxcDU06eakDiMftpo9bavZkywvJPxvfX2scUJr2+7aVE/6iBkv3Vj1jyJ+lMq9yg63MRKe u6Z2tWqp4jb6t+rmFLjuRJP4pVgf79AjsqAecarga7ZzUAWkCsomIVEZyncGpqMk4msODs mmKpYBTZ+uSPDEnAG0NK04wTnspDm8hzev07VdlUY20o4J9TEaiFWSYb7Tpp1nXr7bTTuL Nb2QA7gW3mJj2qa4D88ba7xQt66sRl4dT/ja39ncrfey/cEXfiR8ZY3OlEOt4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694165784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cwUKpwLkYpAL3s43dwEUvPPPNmPUfqic0ShElGLJ8Rs=; b=tGAciIb9TnvaKWPxoOjmhHhblLDXNsOs1hEQecKtMPUSVlvh0Tf3ccuh7m8YdkSXREXJvH z+0AKrtSJR15Fl6q5uLquHoj1qe9dE5dgWDS5xaATbgPpmpryL/wj9dp+6aGleWsFY4pM2 /nUfSgYqzMCu2/cPyCO50P+GfisAqn9mYH+dqTAr+jgIhHVfkzEfhxamwrssV3nbFiV9Zv T9xNbRRjs+dnXDh7LhgE8rCJRoCRjjJXRGPzjX5I9tzBBdQy223DrMDzt0IQMzbF5MvIYv X6CJd7b1NWsmEx3/zBkZosYg62gOQ3zSqD5dcc7efG/h3ixusUncaMJ6mL0GsA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RhrbD3bStzcmZ for ; Fri, 8 Sep 2023 09:36:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3889aOjM062522 for ; Fri, 8 Sep 2023 09:36:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3889aObI062521 for freebsd-arm@FreeBSD.org; Fri, 8 Sep 2023 09:36:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-arm@FreeBSD.org Subject: [Bug 273634] allwinner clk_ng fake divisors/multipliers Date: Fri, 08 Sep 2023 09:36:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: arm X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: titus@edc.ro X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-arm@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273634 Bug ID: 273634 Summary: allwinner clk_ng fake divisors/multipliers Product: Base System Version: Unspecified Hardware: arm64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: arm Assignee: freebsd-arm@FreeBSD.org Reporter: titus@edc.ro when you declare a NMM (or other type) clock with a fake divisor/multiplier and AW_CLK_FACTOR_FIXED flag even if the number of bits/width for the clock= is 0 the value is still set to the register (at the declared shift position) because the value returned by aw_clk_factor_get_value for AW_CLK_FACTOR_FIX= ED is not masked when setting the clock frequency this is causing undesired results the fix would be that aw_clk_factor_get_value to mask the value for=20 AW_CLK_FACTOR_FIXED NM_CLK(spdif_clk, CLK_SPDIF, "spdif", spdif_parents, /* id, name, parents */ 0xC0, /* offset */ 0, 0, 1, AW_CLK_FACTOR_FIXED, /* n factor (fake); */ 0, 4, 0, 0, /* m factor */ 0, 0, /* mux */ 31, /* gate */ AW_CLK_HAS_GATE); /* flags */ bit 0 will be forced to 1 by the n factor and will alter the m factor --=20 You are receiving this mail because: You are the assignee for the bug.=