Date: Mon, 9 Sep 2013 23:51:03 GMT From: Kevin Zheng <kevinz5000@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/181976: [maintainer-update] Fix build for games/bzflag on 10.0-CURRENT Message-ID: <201309092351.r89Np34T067984@oldred.freebsd.org> Resent-Message-ID: <201309100000.r8A000UK091610@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 181976 >Category: ports >Synopsis: [maintainer-update] Fix build for games/bzflag on 10.0-CURRENT >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Sep 10 00:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kevin Zheng >Release: 9.2-RC3 >Organization: >Environment: FreeBSD sigma.local 9.2-RC3 FreeBSD 9.2-RC3 #0 r254795: Sun Aug 25 00:42:01 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC i386 >Description: The following build failures were reported by pkg-fallout: http://beefy2.isc.freebsd.org/bulk/head-default/2013-09-04_22h17m34s/logs/bzflag-2.4.2_2.log http://beefy1.isc.freebsd.org/bulk/head-default/2013-09-04_23h56m58s/logs/bzflag-2.4.2_2.log Clang/LLVM did not accept the default constructor. The fix was obtained and back-ported from the upstream repo. This patch has been tested to work on 8.4-RELEASE and 9.2-RC3, but has NOT been tested on 10.0-CURRENT (due to Redports issues). Please test this patch on a FreeBSD 10 machine to make sure this works. >How-To-Repeat: >Fix: Apply the attached patch. Patch attached with submission follows: diff -ruN /usr/ports/games/bzflag/files/patch-include__VotingArbiter.h bzflag/files/patch-include__VotingArbiter.h --- /usr/ports/games/bzflag/files/patch-include__VotingArbiter.h 1969-12-31 18:00:00.000000000 -0600 +++ bzflag/files/patch-include__VotingArbiter.h 2013-09-06 15:19:11.000000000 -0500 @@ -0,0 +1,19 @@ +--- ./include/VotingArbiter.h.orig 2012-07-15 18:32:02.000000000 -0500 ++++ ./include/VotingArbiter.h 2013-09-06 15:16:49.000000000 -0500 +@@ -231,11 +231,11 @@ + }; + + +-inline VotingArbiter::VotingArbiter(unsigned short int voteTime=60, +- unsigned short int vetoTime=20, +- unsigned short int votesRequired=2, +- float votePercentage=50.1, +- unsigned short int voteRepeatTime=300) ++inline VotingArbiter::VotingArbiter(unsigned short int voteTime, ++ unsigned short int vetoTime, ++ unsigned short int votesRequired, ++ float votePercentage, ++ unsigned short int voteRepeatTime) + : _votingBooth(NULL), + _maxVotes(votesRequired+1), + _voteTime(voteTime), >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309092351.r89Np34T067984>