From nobody Tue Feb 25 13:33:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z2JTF3Tcnz5psxf; Tue, 25 Feb 2025 13:33:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z2JTF2snSz3t3k; Tue, 25 Feb 2025 13:33:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740490401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0bw8qQOKtyKxT/egx8mCAZjxcBHDdMnyS4h+qPhynEE=; b=n9EazGtLSBKXppNt7ROgJ1kTnvfZ2KIlEeYLhy/6UdLLlZGa7tdhIQbpC6ex7mAlM/eXE+ BTOWYAZ4Rtqd9yeqbod2Eu4DDtghMWtLYEAoh9+VW9ACQHGIlgqDgBd13K3h9UCGMIA5FH ETp53YWsWIs/wmKKnJnCRT3M28kn66myQaqBAjNMj3SJY1rnU7/ot3hGQqYh1XLDsq8s/x dHedRgMhx0og+AO63yZckoN3GGNAF9SILgKbrj4ebUTi6w2cA2fHnpFTfF209ahqn8XEDi gKVVV86B2KOdkqMOjiquDj6EdF35eWbFSriMPTlDJMtZvIVhthSF9G34z/LG/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740490401; a=rsa-sha256; cv=none; b=dyuwb0j0JsTGiL7tCCfUx4rHaHfpFrAVjraRl13aQ9TMaPx/yYbgkNtjWD3RxhM+i10QBb LYqYx95eDpiy/iiUfbm8s5lnr+Nufs19Ud52ZFYs3Xu6dJamJ15cIniV76CyeZppgPdvr0 PCEYQ9t/ekBwKB6PiyFhmWq9clsDHYMLcFhY0BB88V5jxiBfCWekPsoIG8wNO4bsnnZxAu eqEWgWDokCK5El4uayAVSHfKu/1YrikxfEE9nVp5YGN0uZl67rq5NTYLXBagQBQWDtzIPn Zq0kcvicVOre+OZSm5qWXzGgzWO9NSgjDYw1sN+4aIsSkR2/EAkznEizSLJiCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740490401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0bw8qQOKtyKxT/egx8mCAZjxcBHDdMnyS4h+qPhynEE=; b=IDOd3IaRzeSs/8pkThSSwlYvrLMBEtKg15wa9zG1tsCmEM6kQx0d8whY6ZoP3iLrDd4irx onWpps2UhXHw1n0DizhK+F5r03a+K5f6ezcIUEX4QEJquIn/1jblJsNuE3ee5yjuVL7fez TxxfTm0PyaXcErwmDtdILqknGbaRribC7j/eyofyu+OS8B5c8dXn2HCtg22UHy1yNqUwWi 6yiCs3dkDYeDV1tlUg2NEDzYxHCb9Wifz/wKkprzWPa/LAvVSsc5GMKjcgpywYTH49Kzl/ J+azp2OOqJ9B/cJWQOBmYEZO5MPAty+tIpSOxDBxl4nffhxtA7kHuVvlP8KmNw== Received: from [IPV6:2601:5c0:4200:b830:7494:dfe3:4196:8949] (unknown [IPv6:2601:5c0:4200:b830:7494:dfe3:4196:8949]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z2JTF0hssz4tr; Tue, 25 Feb 2025 13:33:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 25 Feb 2025 08:33:20 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 93b4a5445658 - main - netgraph: prevent panic with INVARIANTS-enabled kernel Content-Language: en-US To: Eugene Grosbein , Zhenlei Huang Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , "Herbert J. Skuhra" References: <202502250722.51P7Mwnr064433@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/25/25 04:37, Eugene Grosbein wrote: > 25.02.2025 14:59, Zhenlei Huang wrote: > >>> commit 93b4a54456589e78dcd37f2db8333baff3f3f0b2 >>> Author: Eugene Grosbein >>> AuthorDate: 2025-02-25 07:18:29 +0000 >>> Commit: Eugene Grosbein >>> CommitDate: 2025-02-25 07:22:53 +0000 >>> >>> netgraph: prevent panic with INVARIANTS-enabled kernel >>> >>> This change makes NG_ABI_VERSION depend on INVARIANTS >>> in addition to NETGRAPH_DEBUG. >>> >>> PR: 257876 >> >> Maybe a wrong PR ? >> >> The PR 257876 is about port math/deal.ii , I do not see any relationship between it and netgraph(3) or netgraph(4). > > Sorry, paste error. Right number is 214624. The best way to probably rectify this is to go add a comment in PR 257876 saying that the commit in comment N (7 in this case) is for PR 214624. Then if someone in the future tries to look up the bug from the commit message that gives them the note in the right place to find the right PR. (We should perhaps codify this as the way to deal with PR mismatches in commit logs) -- John Baldwin