From owner-svn-src-all@FreeBSD.ORG  Tue Aug 31 18:16:32 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D1F5810656C3;
	Tue, 31 Aug 2010 18:16:32 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
	by mx1.freebsd.org (Postfix) with ESMTP id 985A88FC08;
	Tue, 31 Aug 2010 18:16:32 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
	by mx1.stack.nl (Postfix) with ESMTP id 08B9435A860;
	Tue, 31 Aug 2010 20:16:32 +0200 (CEST)
Received: by turtle.stack.nl (Postfix, from userid 1677)
	id E5E6C1732B; Tue, 31 Aug 2010 20:16:31 +0200 (CEST)
Date: Tue, 31 Aug 2010 20:16:31 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: David Xu <davidxu@FreeBSD.org>
Message-ID: <20100831181631.GA31653@stack.nl>
References: <201008310715.o7V7FoSI021421@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201008310715.o7V7FoSI021421@svn.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212047 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Aug 2010 18:16:32 -0000

On Tue, Aug 31, 2010 at 07:15:50AM +0000, David Xu wrote:
> Author: davidxu
> Date: Tue Aug 31 07:15:50 2010
> New Revision: 212047
> URL: http://svn.freebsd.org/changeset/base/212047

> Log:
>   If a process is being debugged, skips job control caused by SIGSTOP/SIGCONT
>   signals, because it is managed by debugger, however a normal signal sent to
>   a interruptibly sleeping thread wakes up the thread so it will handle the
>   signal when the process leaves the stopped state.

>   PR:	150138
>   MFC after:	1 week

> Modified:
>   head/sys/kern/kern_sig.c

> Modified: head/sys/kern/kern_sig.c
> ==============================================================================
> --- head/sys/kern/kern_sig.c	Tue Aug 31 06:22:03 2010	(r212046)
> +++ head/sys/kern/kern_sig.c	Tue Aug 31 07:15:50 2010	(r212047)
>  		if (sig == SIGKILL) {
> +			if (p->p_flag & P_TRACED)
> +				goto out;
>  			/*
>  			 * SIGKILL sets process running.
>  			 * It will die elsewhere.

Hmm, shouldn't SIGKILL kill right away regardless of debuggers?

-- 
Jilles Tjoelker