From owner-freebsd-tokenring Wed Apr 22 06:02:09 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA05987 for freebsd-tokenring-outgoing; Wed, 22 Apr 1998 06:02:09 -0700 (PDT) (envelope-from owner-freebsd-tokenring@FreeBSD.ORG) Received: from heathers2.stdio.com (lile@heathers2.stdio.com [199.89.192.5]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA05907 for ; Wed, 22 Apr 1998 13:02:00 GMT (envelope-from lile@stdio.com) Received: (from lile@localhost) by heathers2.stdio.com (8.8.8/8.8.8) id IAA21298; Wed, 22 Apr 1998 08:59:48 -0400 (EDT) Date: Wed, 22 Apr 1998 08:59:47 -0400 (EDT) From: "Larry S. Lile" To: "Matthew N. Dodd" cc: tokenring@FreeBSD.ORG Subject: Re: code updated In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-tokenring@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Went and looked at the code it looks ok except for a few minor things. > /* do we need a driver callback to frob MTU when/if it changes? */ > ifp->if_mtu=1492; /* Should be TOKENMTU or ISO88025MTU */ We should make that: ifp->if_mtu=ISO88025MTU; > /* 1mb hardware never left the labs */ > if (ifp->if_baudrate == 0) > ifp->if_baudrate = 16000000; /* 1, 4, or 16Mbit default? */ Do we have any concensus on what the default badrate should be? > /* > * this following bit disagrees with both fddi and ethernet examples > * fix it eventually > */ > for (ifa = ifp->if_addrlist; ifa; ifa = ifa->ifa_next) > > if ((sdl = (struct sockaddr_dl *)ifa->ifa_addr) && [snip] I took that code directly from /sys/net/if_ethersubr.c and changed to constants to what seemed the appropriate ISO88025 couterparts. What is the disagreement? Did the iso88025_ioctl get pulled from if_tok.c? Because if it did I just wanted to warn everybody that for some reason I have not pinned down (lack of time) it causes ifconfig to panic my machine. Any clues on what migh be causing it, or is it a lack of code elsewhere (tok_start, tok_init, ...) ? Also I should be putting out a first effort at a /sys/net/is088025.h shortly which should contain most of the constants and such for 802.5. Larry lile@stdio.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-tokenring" in the body of the message