From owner-cvs-all Tue Jul 23 8:27:30 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7869037B400; Tue, 23 Jul 2002 08:27:24 -0700 (PDT) Received: from tesla.distributel.net (nat.MTL.distributel.NET [66.38.181.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09EEC43E6A; Tue, 23 Jul 2002 08:27:22 -0700 (PDT) (envelope-from bmilekic@unixdaemons.com) Received: (from bmilekic@localhost) by tesla.distributel.net (8.11.6/8.11.6) id g6NFQ5b74249; Tue, 23 Jul 2002 11:26:05 -0400 (EDT) (envelope-from bmilekic@unixdaemons.com) Date: Tue, 23 Jul 2002 11:26:05 -0400 From: Bosko Milekic To: Bosko Milekic Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_mbuf.c Message-ID: <20020723112605.A74237@unixdaemons.com> References: <200207231455.g6NEtZen084267@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200207231455.g6NEtZen084267@freefall.freebsd.org>; from bmilekic@FreeBSD.org on Tue, Jul 23, 2002 at 07:55:35AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jul 23, 2002 at 07:55:35AM -0700, Bosko Milekic wrote: > bmilekic 2002/07/23 07:55:35 PDT > > Modified files: > sys/kern subr_mbuf.c > Log: > Introduce mb_free() to the MBP_PERSIST{,ENT} interface. What this means > is that grouped frees will be done as most often as possible without > dropping the cache lock in between. So, for the most part, they'll be > done without the lock being dropped. This is particularly true if you > have something that does a grouped m_getm() or m_getcl() (a cluster and > mbuf at the same time) - most likely getting the buffers from the > same per-CPU cache - and then frees them with m_free{,m}(). Unless > the buffers' underlying buckets were moved, the free will be done without > the lock getting dropped in between. So far, only m_free() has been > shown how to do this, and m_freem() will shortly follow. > > Since I'm here, I also fixed a small (but mostly harmless) type-mismatch > introduced in the last commit. > > Revision Changes Path > 1.22 +70 -17 src/sys/kern/subr_mbuf.c I should also mention that I'm moving a bit of code around internally in that file (not gratuitist, only to make the stuff work) so if anyone else is reading this code, please bear with me as things get settled in once again. Regards, -- Bosko Milekic bmilekic@unixdaemons.com bmilekic@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message