Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 02 Jun 2020 11:31:58 +0000
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        "Emmanuel Vadot" <manu@bidouilliste.com>
Cc:        "Hans Petter Selasky" <hselasky@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r361723 - head/sys/compat/linuxkpi/common/include/linux
Message-ID:  <C7F8A958-0DC8-42C7-AE5B-AAAA28F25336@lists.zabbadoz.net>
In-Reply-To: <20200602123612.fc6dbafe55c2c981cb0ec9a1@bidouilliste.com>
References:  <202006021019.052AJjxk060018@repo.freebsd.org> <20200602123612.fc6dbafe55c2c981cb0ec9a1@bidouilliste.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Jun 2020, at 10:36, Emmanuel Vadot wrote:

>  Hello Hans,
>
> On Tue, 2 Jun 2020 10:19:45 +0000 (UTC)
> Hans Petter Selasky <hselasky@FreeBSD.org> wrote:
>
>> Author: hselasky
>> Date: Tue Jun  2 10:19:45 2020
>> New Revision: 361723
>> URL: https://svnweb.freebsd.org/changeset/base/361723
>>
>> Log:
>>   Implement struct_size() function macro in the LinuxKPI.
>>
>>   MFC after:	1 week
>>   Sponsored by:	Mellanox Technologies
>>
>> Modified:
>>   head/sys/compat/linuxkpi/common/include/linux/kernel.h
>>
>> Modified: head/sys/compat/linuxkpi/common/include/linux/kernel.h
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/sys/compat/linuxkpi/common/include/linux/kernel.h	Tue Jun  2 =

>> 09:45:43 2020	(r361722)
>> +++ head/sys/compat/linuxkpi/common/include/linux/kernel.h	Tue Jun  2 =

>> 10:19:45 2020	(r361723)
>> @@ -555,4 +555,10 @@ linux_ratelimited(linux_ratelimit_t *rl)
>>  	return (ppsratecheck(&rl->lasttime, &rl->counter, 1));
>>  }
>>
>> +#define	struct_size(ptr, field, num) ({ \
>> +	const size_t __size =3D offsetof(__typeof(*(ptr)), field); \
>> +	const size_t __max =3D (SIZE_MAX - __size) / sizeof((ptr)->field[0])=
; =

>> \
>> +	((num) > __max) ? SIZE_MAX : (__size + sizeof((ptr)->field[0]) * =

>> (num)); \
>> +})
>> +
>>  #endif	/* _LINUX_KERNEL_H_ */
>
>  Can you bump FreeBSD_version so I can fix
> https://github.com/freebsd/drm-kmod/ and update the
> graphics/drm-devel-kmod port please ?

I almost wonder if we want a =E2=80=9Clinuxkkpi version=E2=80=9D to check=
 instead.
If there=E2=80=99s a lot more =E2=80=9Cwork=E2=80=9D on the linuxkpi we m=
ight not want to =

bump __FreeBSD_version for every change which can conflict/affect =

external code?

/bz




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C7F8A958-0DC8-42C7-AE5B-AAAA28F25336>