From owner-svn-ports-all@FreeBSD.ORG  Tue Mar  4 10:39:34 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 294C8431;
 Tue,  4 Mar 2014 10:39:34 +0000 (UTC)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9D8A4F3C;
 Tue,  4 Mar 2014 10:39:33 +0000 (UTC)
Received: from lqc.issp.ac.ru [77.236.34.156:33524] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id s24AdU1s063087 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Tue, 4 Mar 2014 14:39:30 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Antoine Brodin <antoine@freebsd.org>
Subject: Re: svn commit: r346968 - head/converters/libiconv
Date: Tue, 04 Mar 2014 10:39:30 +0000
Message-ID: <1617323.9tYKgzxRAl@mercury.ph.man.ac.uk>
User-Agent: KMail/4.12.3 (FreeBSD/9.2-STABLE; KDE/4.12.3; amd64; ; )
In-Reply-To: <CAALwa8khAJy0-1kozwo42=M6Y+maK9Wdqx5coLMfRb65Jqx+2A@mail.gmail.com>
References: <201403032115.s23LFU07023939@svn.freebsd.org>
 <CAALwa8khAJy0-1kozwo42=M6Y+maK9Wdqx5coLMfRb65Jqx+2A@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="ISO-8859-1"
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Adam Weinberger <adamw@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2014 10:39:34 -0000

On Tue, 04 Mar 2014 11:35:56 +0100 Antoine Brodin wrote:
> On Mon, Mar 3, 2014 at 10:15 PM, Adam Weinberger <adamw@freebsd.org> wrote:
> > Author: adamw
> > Date: Mon Mar  3 21:15:30 2014
> > New Revision: 346968
> > URL: http://svnweb.freebsd.org/changeset/ports/346968
> > QAT: https://qat.redports.org/buildarchive/r346968/
> >
> > Log:
> >   Don't unconditionally install DOCS. PORTREVISION bump
> >   for plist change.
> >
> >   PR:           ports/186590
> >   Approved by:  maintainer
> >
> > Modified:
> >   head/converters/libiconv/Makefile
> >   head/converters/libiconv/pkg-plist
> 
> Hi,
> 
> Why didn't you add DOCS to OPTIONS_DEFINE?
> This is the policy for ports that respect the DOCS option.

Besides, there's no reason for bumping PORTREVISION:
plist with default options is the same.

Max