From owner-dev-commits-src-all@freebsd.org Wed Dec 30 03:20:10 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B074B4D38AB; Wed, 30 Dec 2020 03:20:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5GkL4WWzz4WwJ; Wed, 30 Dec 2020 03:20:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 88FDE2FBF8; Wed, 30 Dec 2020 03:20:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f180.google.com with SMTP id v5so10248936qtv.7; Tue, 29 Dec 2020 19:20:10 -0800 (PST) X-Gm-Message-State: AOAM533tZ1XgBd1SBI2YLk/EuROTU/j1co9LXH/4qdDGEo3PMue/9nnj KGuX8CBYktvh0v0la/4Xtd+8Fl2DpFNvmVqtkeg= X-Google-Smtp-Source: ABdhPJzZhgRK813mBdod4uCN4jn+0y7kqKCSEQRhZNSWgSQT7pkqRukcuOK+ZuBwLg99+6puJtyeY3lqQsz+x2gJdYU= X-Received: by 2002:ac8:44cb:: with SMTP id b11mr50494483qto.60.1609298410179; Tue, 29 Dec 2020 19:20:10 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Tue, 29 Dec 2020 21:19:59 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Ryan Libby Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 03:20:10 -0000 On Tue, Dec 29, 2020 at 9:10 PM Ryan Libby wrote: > > On Tue, Dec 29, 2020 at 5:21 PM Kyle Evans wrote: > > > > On Tue, Dec 29, 2020 at 7:00 PM Ryan Libby wrote: > > > > > > On Tue, Dec 29, 2020 at 4:53 PM Kyle Evans wrote: > > > > > > > > On Tue, Dec 29, 2020 at 6:50 PM Kyle Evans wrote: > > > > > > > > > > On Tue, Dec 29, 2020 at 6:38 PM Ryan Libby wrote: > > > > > > > > > > > > On Tue, Dec 29, 2020 at 3:32 PM Kyle Evans wrote: > > > > > > > > > > > > > > Hmm, I hadn't done this because we still have in-tree GCC4.2. Might want to go ahead and skip these tests entirely a level up for 4.2. > > > > > > > > > > > > > > > > > > > Ah, thanks for the reminder. I'll take another look re in-tree gcc. > > > > > > Based on the other commits I've MFC'd, I'm pretty sure it's been > > > > > > broken for months anyway, but I'll see what I can do if the fixes are > > > > > > easy. > > > > > > > > > > > > > > > > This should not be the case, we've been running arm/mips/etc. in CI up > > > > > until the git transition. > > > > > > > > Sorry, arm is irrelevant for this branch- but mips/powerpc/sparc64. > > > > > > Perhaps only x86 was broken... > > > > > > How was tftpd/tests not already broken with alignas from r367305 which > > > MFC'd r358556? > > > > > > > That is an incredibly good question. The latest build for powerpc > > shows that it did in-fact descend into and build libexec/tftpd/tests > > > > > In any case my plan right now is to try to remember the gcc 4.2 > > > voodoo, assess, and fix. Please let me know if you think this needs > > > immediate revert before then. > > > > > > > Nah, I wouldn't expend the energy on a revert, tbh. If you don't get > > it figured out by tomorrow or so, I'll re-test and smack it. > > Okay, what's going on is that the tftpd/tests/Makefile was already not > building the test for gcc < 4.3, due to lack of __COUNTER__. The use of > _Alignas and -std=c11 would require gcc 4.7. If we cared, we would bump > the minimum gcc version required accordingly. However, since there's > no reason to build with gcc >= 4.3 and < 4.7, I don't think we care and > I think the current state of affairs on stable/12 is acceptable. > > I checked powerpc.powerpc64 with in-tree gcc 4.2.1 and buildworld > succeeded. Hopefully ci will be up again soon too. > > I checked amd64 and it failed due to pkru. I don't think we care to fix > that either, but we technically could of course. For amd64 the external > toolchain with gcc 6.4 is broken at the moment but will be fixed after a > few more MFCs. > > Thanks for reviewing this MFC! Excellent, thanks for taking a look (and merging this back)!