From owner-svn-src-user@FreeBSD.ORG Mon Oct 11 16:45:03 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF157106564A; Mon, 11 Oct 2010 16:45:03 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from out-0.mx.aerioconnect.net (out-0-24.mx.aerioconnect.net [216.240.47.84]) by mx1.freebsd.org (Postfix) with ESMTP id 8C6268FC12; Mon, 11 Oct 2010 16:45:03 +0000 (UTC) Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160]) by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id o9BGR4at020055; Mon, 11 Oct 2010 09:27:05 -0700 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137]) by idiom.com (Postfix) with ESMTP id 9607D2D6018; Mon, 11 Oct 2010 09:27:02 -0700 (PDT) Message-ID: <4CB33B04.8070609@freebsd.org> Date: Mon, 11 Oct 2010 09:27:48 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Hans Petter Selasky References: <201010080152.o981q1gJ074407@svn.freebsd.org> <201010111739.25082.hselasky@c2i.net> In-Reply-To: <201010111739.25082.hselasky@c2i.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51 Cc: "src-committers@freebsd.org" , Weongyo Jeong , "svn-src-user@freebsd.org" Subject: Re: svn commit: r213540 - user/weongyo/usb/sys/dev/usb/net X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2010 16:45:03 -0000 On 10/11/10 8:39 AM, Hans Petter Selasky wrote: > On Friday 08 October 2010 03:52:01 Weongyo Jeong wrote: >> Author: weongyo >> Date: Fri Oct 8 01:52:01 2010 >> New Revision: 213540 >> URL: http://svn.freebsd.org/changeset/base/213540 >> >> Log: >> o fixes a regression that setting the promiscuous mode should be >> happened at the taskqueue. It's to avoid a `sleepable after >> non-sleepable' because ioctl handler could be called with holding bpf >> mtx which is a default mutex. >> o defines SLEEPOUT_DRAIN_TASK helper. >> [...] > These taskqueues belong in the network stack and not the USB drivers! And > please understand that you cannot use taskqueues for these commands, because > the events can be executed out of order!!! sounds like we should add an option to taskqueues to fix this then. I'd rather fix the standard facility than make a new one. > --HPS >