Date: Sun, 12 Feb 2012 23:15:35 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Stephen Montgomery-Smith <stephen@missouri.edu> Cc: Chris Rees <utisoft@gmail.com>, freebsd-ports@FreeBSD.org, Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: Please test your commits Message-ID: <4F382BF7.2030302@FreeBSD.org> In-Reply-To: <4F382504.10802@missouri.edu> References: <20120212193927.GA86426@troutmask.apl.washington.edu> <CADLo83_UZR0K15LQWoXb-AAhd1wj25fbeKSAPch5ji_Q=41f8A@mail.gmail.com> <20120212201624.GA86650@troutmask.apl.washington.edu> <4F3820AD.4090702@FreeBSD.org> <20120212204118.GA86775@troutmask.apl.washington.edu> <4F382504.10802@missouri.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
on 12/02/2012 22:45 Stephen Montgomery-Smith said the following: > On 02/12/2012 02:41 PM, Steve Kargl wrote: >> On Sun, Feb 12, 2012 at 10:27:25PM +0200, Andriy Gapon wrote: >>> on 12/02/2012 22:16 Steve Kargl said the following: >>>> You seem to have the faulty belief that this is the first occurence >>>> of this type of issue? >>> >>> So instead of proper report to the port's maintainer (including description of >>> your environment, possibly full build log, etc), possibly with a CC here, you >>> decided to vent out here... >>> >>> Is there any requirement that people do the former and not the latter? :-) >>> >> >> I'm not venting. I'm simply requesting that all committers >> test the code that they intend to commit. It is quite >> clear that this particular commit was not tested. >> >> The environment is irrelevant because malloc.h was poisoned >> 10 years, 3 months ago. As to a full build log, the >> necessary information was included in my original email. > > Except I didn't get the malloc.h error when I tried compiling it. So merely > noting the age of malloc.h doesn't prove that the committer didn't test it. Today I became another user of redports.org. I can definitely recommend it. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F382BF7.2030302>