From owner-freebsd-ports@FreeBSD.ORG Sun Feb 12 21:16:14 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 214961065670 for ; Sun, 12 Feb 2012 21:16:14 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 61D9A8FC0A for ; Sun, 12 Feb 2012 21:16:12 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA11457; Sun, 12 Feb 2012 23:16:06 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1RwgmE-000GZd-Bo; Sun, 12 Feb 2012 23:16:06 +0200 Message-ID: <4F382BF7.2030302@FreeBSD.org> Date: Sun, 12 Feb 2012 23:15:35 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0) Gecko/20120202 Thunderbird/10.0 MIME-Version: 1.0 To: Stephen Montgomery-Smith References: <20120212193927.GA86426@troutmask.apl.washington.edu> <20120212201624.GA86650@troutmask.apl.washington.edu> <4F3820AD.4090702@FreeBSD.org> <20120212204118.GA86775@troutmask.apl.washington.edu> <4F382504.10802@missouri.edu> In-Reply-To: <4F382504.10802@missouri.edu> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Chris Rees , freebsd-ports@FreeBSD.org, Steve Kargl Subject: Re: Please test your commits X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2012 21:16:14 -0000 on 12/02/2012 22:45 Stephen Montgomery-Smith said the following: > On 02/12/2012 02:41 PM, Steve Kargl wrote: >> On Sun, Feb 12, 2012 at 10:27:25PM +0200, Andriy Gapon wrote: >>> on 12/02/2012 22:16 Steve Kargl said the following: >>>> You seem to have the faulty belief that this is the first occurence >>>> of this type of issue? >>> >>> So instead of proper report to the port's maintainer (including description of >>> your environment, possibly full build log, etc), possibly with a CC here, you >>> decided to vent out here... >>> >>> Is there any requirement that people do the former and not the latter? :-) >>> >> >> I'm not venting. I'm simply requesting that all committers >> test the code that they intend to commit. It is quite >> clear that this particular commit was not tested. >> >> The environment is irrelevant because malloc.h was poisoned >> 10 years, 3 months ago. As to a full build log, the >> necessary information was included in my original email. > > Except I didn't get the malloc.h error when I tried compiling it. So merely > noting the age of malloc.h doesn't prove that the committer didn't test it. Today I became another user of redports.org. I can definitely recommend it. -- Andriy Gapon