From owner-cvs-src@FreeBSD.ORG Thu Oct 6 17:58:50 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEF8416A423; Thu, 6 Oct 2005 17:58:50 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F28843D5E; Thu, 6 Oct 2005 17:58:46 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id D159550BC1; Thu, 6 Oct 2005 19:58:44 +0200 (CEST) Received: from localhost (dlc37.neoplus.adsl.tpnet.pl [83.24.32.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id BF21F50B2B; Thu, 6 Oct 2005 19:58:33 +0200 (CEST) Date: Thu, 6 Oct 2005 19:58:32 +0200 From: Pawel Jakub Dawidek To: Nate Lawson Message-ID: <20051006175832.GA26614@garage.freebsd.pl> References: <200510061110.j96BAApc034176@repoman.freebsd.org> <20051006132738.GG603@wombat.fafoe.narf.at> <20051006144454.GF23662@garage.freebsd.pl> <20051006154754.GH603@wombat.fafoe.narf.at> <434560A7.2010603@root.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Content-Disposition: inline In-Reply-To: <434560A7.2010603@root.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng devel (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, Stefan Farfeleder , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h src/sys/conf files X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2005 17:58:51 -0000 --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 06, 2005 at 10:36:39AM -0700, Nate Lawson wrote: +> Stefan Farfeleder wrote: +> >On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote: +> >>On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote: +> >>+> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote: +> >>+> > pjd 2005-10-06 11:10:10 UTC +> >>+> > +> > FreeBSD src repository +> >>+> > +> > Modified files: +> >>+> > sys/sys libkern.h +> > sys/conf = files +> > Added files: +> >>+> > sys/libkern strtok.c +> > Log: +> >>+> > Add strtok() and strtok_r() function to libkern. +> >>+> +> Wouldn't it be better to have strsep() instead? +> >>Actually we do have strsep() libkern already... +> >Oops. Can you please change nfs_diskless.c to use strsep()? I think +> >it's a mistake to add non-reentrant functions to libkern. +> >Stefan +>=20 +> Agreed. I wanted to use it to parse options for NFS root file system. There is no race risk there, but I added also strtok_r() function. That was my thinking back then. I was wrong, I should look closer for strsep() in libkern and just use it. Sorry for the mess I'll back it out after some testing of setsep() version. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDRWXIForvXbEpPzQRAg4PAKC1e7GUo63kduOelHyTJRErBUIMOQCfUoCC luQlId7Tf1lBaIVQSE5tZgI= =fpto -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--