From owner-svn-src-projects@FreeBSD.ORG  Wed Sep 15 16:40:17 2010
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AE18510656A4;
	Wed, 15 Sep 2010 16:40:17 +0000 (UTC)
	(envelope-from attilio@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F3CA8FC14;
	Wed, 15 Sep 2010 16:40:17 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o8FGeHwO043104;
	Wed, 15 Sep 2010 16:40:17 GMT (envelope-from attilio@svn.freebsd.org)
Received: (from attilio@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o8FGeHUM043102;
	Wed, 15 Sep 2010 16:40:17 GMT (envelope-from attilio@svn.freebsd.org)
Message-Id: <201009151640.o8FGeHUM043102@svn.freebsd.org>
From: Attilio Rao <attilio@FreeBSD.org>
Date: Wed, 15 Sep 2010 16:40:17 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r212674 - projects/sv/sys/netinet
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Sep 2010 16:40:17 -0000

Author: attilio
Date: Wed Sep 15 16:40:17 2010
New Revision: 212674
URL: http://svn.freebsd.org/changeset/base/212674

Log:
  ether_set_broadcast() is just one line and just called once.
  Inline it directly as it cuts some code.
  
  Submitted by:	emaste

Modified:
  projects/sv/sys/netinet/netdump_client.c

Modified: projects/sv/sys/netinet/netdump_client.c
==============================================================================
--- projects/sv/sys/netinet/netdump_client.c	Wed Sep 15 16:37:31 2010	(r212673)
+++ projects/sv/sys/netinet/netdump_client.c	Wed Sep 15 16:40:17 2010	(r212674)
@@ -153,24 +153,6 @@ static int nd_polls=10000; /* Times to p
 static int nd_retries=10; /* Times to retransmit lost packets */
 
 /*
- * [ether_set_broadcast]
- *
- * Fills up an ethernet address as broadcast
- *
- * Parameters:
- *	addr	The ethernet address to be filled up
- *
- * Returns:
- *	void
- */
-static __inline void
-ether_set_broadcast(struct ether_addr *addr)
-{
-
-	memset(addr, 0xFF, ETHER_ADDR_LEN);
-}
-
-/*
  * [netdump_supported_nic]
  *
  * Checks for netdump support on a network interface
@@ -515,8 +497,8 @@ netdump_send_arp()
 	struct arphdr *ah;
 	struct ether_addr bcast;
 
-	ether_set_broadcast(&bcast);
-
+	/* Fill-up a broadcast address. */
+	memset(&bcast, 0xFF, ETHER_ADDR_LEN);
 	MGETHDR(m, M_DONTWAIT, MT_DATA);
 	if (m == NULL) {
 		printf("netdump_send_arp: Out of mbufs");