From owner-freebsd-current  Wed Sep 24 17:14:02 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id RAA09775
          for current-outgoing; Wed, 24 Sep 1997 17:14:02 -0700 (PDT)
Received: from usr03.primenet.com (tlambert@usr03.primenet.com [206.165.6.203])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id RAA09770
          for <current@FreeBSD.ORG>; Wed, 24 Sep 1997 17:14:00 -0700 (PDT)
Received: (from tlambert@localhost)
	by usr03.primenet.com (8.8.5/8.8.5) id RAA01429;
	Wed, 24 Sep 1997 17:10:56 -0700 (MST)
From: Terry Lambert <tlambert@primenet.com>
Message-Id: <199709250010.RAA01429@usr03.primenet.com>
Subject: Re: Daily SNAPshots at current.freebsd.org shut down for now.
To: kato@migmatite.eps.nagoya-u.ac.jp (KATO Takenori)
Date: Thu, 25 Sep 1997 00:10:55 +0000 (GMT)
Cc: phk@critter.freebsd.dk, current@FreeBSD.ORG
In-Reply-To: <199709241017.TAA01768@gneiss.eps.nagoya-u.ac.jp> from "KATO Takenori" at Sep 24, 97 07:17:40 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> > disable clustering on a per filesystem or mount point basis and disallow
> > it for vn devices.  If you think about it, it doesn't make sense in the
> > first place.
> 
> How about following following patch?

[ ... ]

[ ... ]
> ! 		else if (doclusterread && !(vp->v_flag & VNOCLUSTER))

Poul's right... this needs to be per FS type instead (and maybe a mount
option, like he suggested, though it shouldn't be allowed to override "on",
and "off" is only marginally useful at best.  I would think you'd be
able to roll it into per fs "doclusterread" and "doclusterwrite" and
save the extra comparisons, for the most part, as well.

It *does* look like this is the right way out of the kludge, however.


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.