From owner-cvs-all Tue Dec 11 12:18:19 2001 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id EC42137B416; Tue, 11 Dec 2001 12:18:08 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id fBBKI7a81983; Tue, 11 Dec 2001 13:18:08 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost [127.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id fBBKI7M29965; Tue, 11 Dec 2001 13:18:07 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200112112018.fBBKI7M29965@harmony.village.org> To: "Justin T. Gibbs" Subject: Re: cvs commit: src/sys/dev/usb usbdevs.h usbdevs_data.h Cc: "Erik H. Bakke" , "Sheldon Hearn" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Tue, 11 Dec 2001 13:14:54 MST." <200112112014.fBBKEsg72815@aslan.scsiguy.com> References: <200112112014.fBBKEsg72815@aslan.scsiguy.com> Date: Tue, 11 Dec 2001 13:18:07 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200112112014.fBBKEsg72815@aslan.scsiguy.com> "Justin T. Gibbs" writes: : >In message <200112111822.fBBIMxg69086@aslan.scsiguy.com> "Justin T. Gibbs" wri : >tes: : >: All that this central database does is prevent you from shipping a : >: binary module for a new device and have it be properly announced : >: unless you have a new usb core module too. Just put these entries into : >: the individual drivers and have them call a common routine in the USB : >: code to export the entry on attach. : > : >Yes. That's true. You don't have to have them in the central : >database. I'm not sure why we have the central database array in the : >kernel, since we did eliminate it for the pccard side of things. The : >generated .h files provide a common and convenient way to do the USB : >device stuff. It also makes sharing with NetBSD easier. We do a fair : >amount of device list sharing with NetBSD on the pccard side of : >things. : : I guess I don't see a large benefit to sharing IDs with NetBSD so long : as they insist on a clunky global list generation of IDs. If I'm a : third party creating a binary only module, my IDs and table entries : are not going to be in that list. I have to be able to do everything : from within my module and perhaps self contained source tree I use : to build that module. Sigh. You've not looked at the ed driver's list of devices then. It is quite large. The global list is useful. Since it is optional, third party vendors are free to use their own stuff, or even to have their own small files they can then use the scripts we have to create the lists. The central database means we don't have to repeat vendor IDs in all the different driver's config files. : >: Matchin usb devices certainly looks to be as simple as PCI. From : >: if_aue.c: : > : >For aue it is. There are some devices I'm told that you need to look : >at the vendor strings themselves. I know that's true for pccard : >because vendor's CIS have varied wildly over time. : : Which just goes to show you that generic code cannot handle every : device, so we should export the tools to the modules and let them : figure out the best way to probe for their device. But the pccard code already handles all the cases I'm aware of in the tree. These thigns are useful. Let's not move away from them. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message