From owner-freebsd-hardware@FreeBSD.ORG  Wed Jun  9 20:52:58 2004
Return-Path: <owner-freebsd-hardware@FreeBSD.ORG>
Delivered-To: freebsd-hardware@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 055BD16A4CE
	for <freebsd-hardware@freebsd.org>;
	Wed,  9 Jun 2004 20:52:58 +0000 (GMT)
Received: from smsgw.vianetworks.ch (smsgw.vianetworks.ch [146.228.10.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6F37443D45
	for <freebsd-hardware@freebsd.org>;
	Wed,  9 Jun 2004 20:52:57 +0000 (GMT)
	(envelope-from mw@smsgw.vianetworks.ch)
Received: from smsgw.vianetworks.ch (localhost.kpnqwest.ch [127.0.0.1])
	by smsgw.vianetworks.ch (8.12.10/8.12.6) with ESMTP id i59Kqhhm068487;
	Wed, 9 Jun 2004 22:52:43 +0200 (CEST)
	(envelope-from mw@smsgw.vianetworks.ch)
Received: (from mw@localhost)
	by smsgw.vianetworks.ch (8.12.10/8.12.6/Submit) id i59Kqhre068486;
	Wed, 9 Jun 2004 22:52:43 +0200 (CEST)
Message-Id: <200406092052.i59Kqhre068486@smsgw.vianetworks.ch>
In-Reply-To: <40C75F55.ABD6CBB8@lbl.gov>
To: "Jin Guojun [DSD]" <g_jin@lbl.gov>
Date: Wed, 9 Jun 2004 22:52:43 +0200 (CEST)
Sender: mw@smsgw.vianetworks.ch
From: Markus Wild <mwild@vianetworks.ch>
X-NCC-RegID: ch.vianetworks
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
cc: Markus Wild <mwild@vianetworks.ch>
cc: freebsd-hardware@freebsd.org
Subject: Re: Fix for Logitech DiNovo cordless mouse
X-BeenThere: freebsd-hardware@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: General discussion of FreeBSD hardware
	<freebsd-hardware.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hardware>,
	<mailto:freebsd-hardware-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hardware>
List-Post: <mailto:freebsd-hardware@freebsd.org>
List-Help: <mailto:freebsd-hardware-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hardware>,
	<mailto:freebsd-hardware-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jun 2004 20:52:58 -0000

> By looking the code, the fix should be something like in attachment.
> Since I have not such device, I cannot test it.
> Let me know if attached patch works.

No, it did not. Reason is you're exiting out of the loop
too early this way, and a side effect of the loop is determining
the size of the request... 

Your version:
Jun  9 22:36:27 mothra kernel: ums_attach: bLength=7 bDescriptorType=5 bEndpointAddress=2-in bmAttributes=3 wMaxPacketSize=8 bInterval=10
Jun  9 22:36:27 mothra kernel: ums0: 7 buttons and Z dir.
...
Jun  9 22:36:27 mothra kernel: ums_attach: size=1, id=2

Mine:
Jun  9 22:46:53 mothra kernel: ums_attach: bLength=7 bDescriptorType=5 bEndpointAddress=2-in bmAttributes=3 wMaxPacketSize=8 bInterval=10
Jun  9 22:46:53 mothra kernel: ums0: 7 buttons and Z dir.
...
Jun  9 22:46:53 mothra kernel: ums_attach: size=36, id=2

Cheers,
Markus