From owner-svn-src-all@freebsd.org Tue Jan 7 06:43:05 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 36FDA1E7ED5; Tue, 7 Jan 2020 06:43:05 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47sN9g2YmMz3HHg; Tue, 7 Jan 2020 06:43:03 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id oiZuiIPzc17ZDoiZwiyKYV; Mon, 06 Jan 2020 23:43:01 -0700 X-Authority-Analysis: v=2.3 cv=ZsqT1OzG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=Jdjhy38mL1oA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=ic_SNM59hN71-EiAzz4A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 5871C1B1; Mon, 6 Jan 2020 22:42:58 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id 0076gwdn026498; Mon, 6 Jan 2020 22:42:58 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id 0076gvXR026495; Mon, 6 Jan 2020 22:42:57 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202001070642.0076gvXR026495@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "O. Hartmann" cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356437 - head/lib/libprocstat In-reply-to: <20200107064255.18dad9d2@freyja> References: <202001070533.0075XX7D076100@repo.freebsd.org> <20200107064255.18dad9d2@freyja> Comments: In-reply-to "O. Hartmann" message dated "Tue, 07 Jan 2020 06:43:02 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 06 Jan 2020 22:42:57 -0800 X-CMAE-Envelope: MS4wfDcz/qUhnkRTyKL2Is1dfJ8I0UVCjAgXSAyjCO8ukCM3ZKj9KanSP1alQ46zeK6W35CVpnnImBdlt0kMrG5YTxPqhlqY2GdMNTLqqT2V7jZmVh8pV50Y YisQyVbX05awpTQj3rZmUxkNd0vUxDZPeQSVN3wEdaPEJTZyZ5HyXWgfmi13bwZAoFyg0XoIkmLCY+QPSa9DW9YtKxRutra8uA3gwtyBSnXDWH4zeRYbYTfw YVdfYQTxWy+1A0rBApdu90dhcxSyoNIinjpqkIt8lt5+iVoNFrhGOQtua+L7oVABBZQVYO7ySvIsSdAASN3/jCQkM+kt29PNcBOjkRTMpfA= X-Rspamd-Queue-Id: 47sN9g2YmMz3HHg X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.139) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.30)[ip: (-5.83), ipnet: 64.59.128.0/20(-3.13), asn: 6327(-2.43), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[139.136.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2020 06:43:05 -0000 In message <20200107064255.18dad9d2@freyja>, "O. Hartmann" writes: > On Tue, 7 Jan 2020 05:33:33 +0000 (UTC) > Mateusz Guzik wrote: > > > Author: mjg > > Date: Tue Jan 7 05:33:33 2020 > > New Revision: 356437 > > URL: https://svnweb.freebsd.org/changeset/base/356437 > > > > Log: > > procstat: read lo_name instead of now removed v_tag > > > > Modified: > > head/lib/libprocstat/libprocstat.c > > > > Modified: head/lib/libprocstat/libprocstat.c > > =========================================================================== > === > > --- head/lib/libprocstat/libprocstat.c Tue Jan 7 04:34:29 2020 > > (r356436) +++ head/lib/libprocstat/libprocstat.c Tue Jan 7 05:33:33 > > 2020 (r356437) @@ -1278,10 +1278,10 @@ > > procstat_get_vnode_info_kvm(kvm_t *kd, struct filestat vn->vn_type = > > vntype2psfsttype(vnode.v_type); if (vnode.v_type == VNON || vnode.v_type == > > VBAD) return (0); > > - error = kvm_read_all(kd, (unsigned long)vnode.v_tag, tagstr, > > - sizeof(tagstr)); > > + error = kvm_read_all(kd, (unsigned > > long)vnode.v_lock.lock_object.lo_name, > > + tagstr, sizeof(tagstr)); > > if (error == 0) { > > - warnx("can't read v_tag at %p", (void *)vp); > > + warnx("can't read lo_name at %p", (void *)vp); > > goto fail; > > } > > tagstr[sizeof(tagstr) - 1] = '\0'; > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > This commit makes buildworld to fail: > > [...] > --- lib/libprocstat__L --- > /usr/src/lib/libprocstat/libprocstat.c:848:2: warning: variable 'files' is us > ed > uninitialized whenever switch default is taken [-Wsometimes-uninitialized] > default: ^~~~~~~ > /usr/src/lib/libprocstat/libprocstat.c:851:6: note: uninitialized use occurs > here if (files == NULL && errno != EPERM) { > ^~~~~ > /usr/src/lib/libprocstat/libprocstat.c:827:32: note: initialize the variable > 'files' to silence this warning struct kinfo_file *kif, *files; > ^ > = NULL > /usr/src/lib/libprocstat/libprocstat.c:1281:48: error: no member named 'v_tag > ' > in 'struct vnode' > > [...] > > Kind regards, > > oh > > It would appear you don't have this commit in your tree. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.