From owner-cvs-all@FreeBSD.ORG Mon Jun 11 19:00:10 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5827416A469 for ; Mon, 11 Jun 2007 19:00:10 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id B413313C4B9 for ; Mon, 11 Jun 2007 19:00:09 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 92532 invoked from network); 11 Jun 2007 18:13:51 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 11 Jun 2007 18:13:51 -0000 Message-ID: <466D9BBB.1060601@freebsd.org> Date: Mon, 11 Jun 2007 21:00:11 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: Andrew Gallatin References: <200706111459.l5BExvTp020932@repoman.freebsd.org> In-Reply-To: <200706111459.l5BExvTp020932@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/net if_ethersubr.c src/sys/dev/mxge mxge_lro.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 19:00:10 -0000 Andrew Gallatin wrote: > gallatin 2007-06-11 14:59:56 UTC > > FreeBSD src repository > > Modified files: > sys/sys mbuf.h > sys/net if_ethersubr.c > sys/dev/mxge mxge_lro.c > Log: > Allow drivers, such as cxgb and mxge, which support LRO to bypass > the MTU check in ether_input() on LRO merged frames. > > Discussed with: kmacy Not discussed with: andre Your change isn't the right way to make this work. LRO is an interface capability (that should have the option to disable it) and the test in ether_input() should go on that instead. LRO is not an information that is needed beyond ether_input() and thus doesn't have to be a mbuf flag. I've indicated that I'm working in this area as well and at least dropping an email or a ping IRC would have been nice. I would have told you the above right away. My common version of LRO isn't ready yet as I'm a bit short on time and I chose to concentrate on TCP it- self. We only have to make sure that we don't exclude a common LRO implementation due to API/ABI issues for 7.1R. -- Andre