From owner-freebsd-stable@FreeBSD.ORG  Thu May  1 19:41:49 2014
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BF0753DD;
 Thu,  1 May 2014 19:41:49 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 986C4152E;
 Thu,  1 May 2014 19:41:49 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 28D81B97B;
 Thu,  1 May 2014 15:41:48 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Don Lewis <truckman@freebsd.org>
Subject: Re: Thinkpad R60 hangs when booting recent 8.4-STABLE
Date: Thu, 1 May 2014 14:33:37 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; )
References: <201405010555.s415tfL6034493@gw.catspoiler.org>
In-Reply-To: <201405010555.s415tfL6034493@gw.catspoiler.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201405011433.37678.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 01 May 2014 15:41:48 -0400 (EDT)
Cc: stable@freebsd.org
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2014 19:41:49 -0000

On Thursday, May 01, 2014 1:55:41 am Don Lewis wrote:
> On 30 Apr, John Baldwin wrote:
> 
> > Are you up for doing some printf sleuthing?  There are two odd things that I 
> > see so far:
> > 
> > 1) the base address of 0.  The question here is if pci_add_map() in 
> > sys/dev/pci/pci.c decides to set start to 0 explicitly, or if it happens 
> > further up the callchain (should be bus_alloc_resource calls in 
> > sys/dev/acpica/acpi_pcib_acpi.c, sys/x86/x86/nexus.c and then in the
> > rman code itself in sys/kern/subr_rman.c)
> > 
> > 2) The 'reserved' printfs during boot probe.  Those come from a printf in 
> > pci_alloc_resource() in sys/dev/pci/pci.c.  However, that should not be called 
> > until a driver attaches to a device and calls bus_alloc_resource().  It should 
> > not be called from pci_add_child() as it seems to be now.
> 
> The call graph for the four earlier ones that you previously pointed
> out (not hostb0) is:
> 	pci_add_child()
> 		pci_add_resources()
> 			*_early_takeover()
> 				[I suspect]
> 				bus_alloc_resource_any()
> 					pci_alloc_resource()
> 					
> These are the three system uhci controllers and the system ehci
> controller, which apparently pass this test:
> 	pci_get_class(dev) == PCIC_SERIALBUS &&
> 	pci_get_subclass(dev) == PCIS_SERIALBUS_USB

Oh, ok.  That is fine, and that explains why it was selective in the past (and
only for I/O resources).  That just leaves 1) then.  It would be especially good
to know what pci_add_map() does when it sees this BAR during the bus probe.

-- 
John Baldwin