From owner-freebsd-ports@freebsd.org Sun Dec 30 00:41:43 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A6B5143205D for ; Sun, 30 Dec 2018 00:41:43 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [140.82.23.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E2DA08BC90 for ; Sun, 30 Dec 2018 00:41:41 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from duke.gem.co (cpe-23-243-162-239.socal.res.rr.com [23.243.162.239]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 59047f00 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Sat, 29 Dec 2018 16:41:33 -0800 (PST) Subject: Re: Request for help: remove bundler from ruby 2.6 port To: Adam Weinberger , Yasuhiro KIMURA Cc: freebsd-ports@freebsd.org References: <20181229.134412.1093009159948437947.yasu@utahime.org> From: Pete Wright Message-ID: <06f8f9d9-f949-d57c-c654-14ce82b086cf@nomadlogic.org> Date: Sat, 29 Dec 2018 16:41:32 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: E2DA08BC90 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 140.82.23.70 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-5.69 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[239.162.243.23.zen.spamhaus.org : 127.0.0.10]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.nomadlogic.org]; NEURAL_HAM_SHORT(-0.92)[-0.923,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-2.46)[ip: (-9.13), ipnet: 140.82.16.0/21(-4.56), asn: 20473(1.46), country: US(-0.08)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:20473, ipnet:140.82.16.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Dec 2018 00:41:43 -0000 On 12/29/18 2:34 PM, Adam Weinberger wrote: > On Sat, Dec 29, 2018 at 6:20 AM Yasuhiro KIMURA wrote: >> Hello all, >> >> Ruby 2.6.0 is released and I tried porting it. >> >> After creating start point by 'svn copy lang/ruby25 lang/ruby26', I >> made following changes. >> >> https://www.utahime.org/FreeBSD/ports/lang_ruby26.patch >> >> It is build successfully and works fine on 12.0-RELEASE amd64. But >> there is still one issue left. >> >> From 2.6.0 ruby includes 'bundler'. But according to the convention of >> ruby port it should be removed from ruby core port in the same way as >> 'gem' and 'rake'. I learned from Makefile that it is achieved by >> removing related files from source tree at post-patch target. However >> I don't know enough about what files need to be removed to cleanly >> remove bundler from ruby 2.6 port. >> >> So would someone please help me about it? > I think perhaps it's worth considering doing the opposite and, > beginning with 2.6, install the entire standard library by default. > Gems and stdlib exist side-by-side without problem, and many of the > gems that are deleted are generally kept up-to-date. > > Even if we don't want to install the entire standard library, I'd at > least strongly argue for including the most important gems (rake, gem, > minitest, and bundler) by default. They are basic components of ruby > itself, and ports should provide //optional// newer versions of them. +1 from me on this. i think the benefits of lowering the porting overhead combined with the fact that most ruby envs i've supported (and currently support) are built around the expectation that rake, gem and bundler are all available - so this would lower my administrative overhead as well. i will hopefully have time to give your patch a test on my end this weekend and send some feedback. cheers, -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA