From owner-freebsd-stable@FreeBSD.ORG Tue Aug 12 20:20:25 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C7AAFFF; Tue, 12 Aug 2014 20:20:25 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D584E2BB7; Tue, 12 Aug 2014 20:20:24 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 51849B917; Tue, 12 Aug 2014 16:20:21 -0400 (EDT) From: John Baldwin To: freebsd-stable@freebsd.org Subject: Re: bsd.sys.mk [-Wno-uninitialized] Date: Tue, 12 Aug 2014 16:07:21 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <20140704123901.GR6056@albert.catwhisker.org> <771D269B-AC6D-4686-ABB0-04F7DCD3A8D9@FreeBSD.org> <53C4F39E.2030407@selasky.org> In-Reply-To: <53C4F39E.2030407@selasky.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201408121607.21743.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 12 Aug 2014 16:20:21 -0400 (EDT) Cc: Hans Petter Selasky , Dimitry Andric , stable@freebsd.org, David Chisnall , "current@freebsd.org" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 20:20:25 -0000 On Tuesday, July 15, 2014 5:25:50 am Hans Petter Selasky wrote: > On 07/05/14 15:10, David Chisnall wrote: > > On 5 Jul 2014, at 14:07, Dimitry Andric wrote: > > > >> Interestingly, -Wno-uninitialized has been in bsd.sys.mk since r76861, > >> and the accompanying comment ("XXX Delete -Wuninitialized by default for > >> now -- the compiler doesn't always get it right") has never been > >> changed. :-) > >> > >> It is probably time to re-enable that warning after 13 years, at least. > > > > It probably only wants enabling for clang. GCC (at least, GCC 4.2.1) performs this analysis based on analyses run by the optimisers and so the warnings are dependent on optimisation level. > > > > David > > Hi, > > Is someone working on this? If not, at least add a PR so it is harder to drop? -- John Baldwin