Date: Tue, 13 Mar 2012 20:21:25 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Alexander Best <arundel@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232894 - head/contrib/llvm/tools/clang/lib/Basic Message-ID: <4F5F9E35.5030602@FreeBSD.org> In-Reply-To: <20120313021545.GA61307@freebsd.org> References: <201203122107.q2CL7MYo086974@svn.freebsd.org> <20120313021545.GA61307@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-03-13 03:15, Alexander Best wrote: > On Mon Mar 12 12, Dimitry Andric wrote: >> Author: dim >> Date: Mon Mar 12 21:07:22 2012 >> New Revision: 232894 >> URL: http://svn.freebsd.org/changeset/base/232894 >> >> Log: >> Pull in r145194 from upstream clang trunk: >> >> Make our handling of MMX x SSE closer to what gcc does: >> >> * Enabling sse enables mmx. >> * Disabling (-mno-mmx) mmx, doesn't disable sse (we got this right already). >> * The order in not important. -msse -mno-mmx is the same as -mno-mmx -msse. > > are you sure that sys/conf/kern.mk doesn't need updating after this commit? if > now setting -mno-mmx doesn't imply -mno-sse, i think the i386 and amd64 > sections in kern.mk needs to be updated (along with the comments). Setting -mno-mmx never implied -mno-sse, even before r232894. I have updated the comments and CFLAGS in r232933. Note that clang's default arch setting on 32-bit x86 is i486, so it would not have been using SSE anyway. That is, unless people set CPUTYPE to anything that does support it. :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F5F9E35.5030602>