From owner-svn-src-user@freebsd.org Sun Mar 11 10:06:12 2018
Return-Path: <owner-svn-src-user@freebsd.org>
Delivered-To: svn-src-user@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2195F410BE
for <svn-src-user@mailman.ysv.freebsd.org>;
Sun, 11 Mar 2018 10:06:12 +0000 (UTC)
(envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client did not present a certificate)
by mx1.freebsd.org (Postfix) with ESMTPS id 3644084BA6;
Sun, 11 Mar 2018 10:06:12 +0000 (UTC)
(envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w2BA60sv035221
(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
Sun, 11 Mar 2018 12:06:04 +0200 (EET)
(envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w2BA60sv035221
Received: (from kostik@localhost)
by tom.home (8.15.2/8.15.2/Submit) id w2BA609t035220;
Sun, 11 Mar 2018 12:06:00 +0200 (EET)
(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
using -f
Date: Sun, 11 Mar 2018 12:06:00 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Jeff Roberson <jeff@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: Re: svn commit: r330755 - user/jeff/numa/sys/vm
Message-ID: <20180311100600.GB76926@kib.kiev.ua>
References: <201803110245.w2B2jrhF037791@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201803110245.w2B2jrhF037791@repo.freebsd.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the experimental " user"
src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-user>,
<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user/>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-user>,
<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Mar 2018 10:06:13 -0000
On Sun, Mar 11, 2018 at 02:45:53AM +0000, Jeff Roberson wrote:
> Author: jeff
> Date: Sun Mar 11 02:45:52 2018
> New Revision: 330755
> URL: https://svnweb.freebsd.org/changeset/base/330755
>
> Log:
> Leave a note for myself to cleanup some locking before commit to head.
>
> Modified:
> user/jeff/numa/sys/vm/vm_page.c
>
> Modified: user/jeff/numa/sys/vm/vm_page.c
> ==============================================================================
> --- user/jeff/numa/sys/vm/vm_page.c Sun Mar 11 01:09:31 2018 (r330754)
> +++ user/jeff/numa/sys/vm/vm_page.c Sun Mar 11 02:45:52 2018 (r330755)
> @@ -3374,6 +3374,7 @@ vm_page_free_pages_toq(struct spglist *free, bool upda
> while ((m = SLIST_FIRST(free)) != NULL) {
> count++;
> SLIST_REMOVE_HEAD(free, plinks.s.ss);
> + /* XXX batch locks. */
> vm_page_lock(m);
> if (vm_page_free_prep(m, false))
> TAILQ_INSERT_TAIL(&pgl, m, listq);
Is the added vm_page_lock() due to the new uses of vm_page_free_pages_toq() ?
I believe that the function was only used for the unmanaged pages.