From owner-freebsd-current@freebsd.org Tue May 12 22:10:01 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F3A72DD7D6 for ; Tue, 12 May 2020 22:10:01 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49MBn42kWwz42rV for ; Tue, 12 May 2020 22:09:59 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.160] (cpe-23-243-161-111.socal.res.rr.com [23.243.161.111]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 885a5784 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 12 May 2020 22:09:53 +0000 (UTC) Subject: Re: lockups on lenovo p43s under current From: Pete Wright To: Yuri Pankov , FreeBSD Current References: <7cd71bcc-5d3c-594f-9c06-3aea48aedc63@fastmail.com> Message-ID: Date: Tue, 12 May 2020 15:09:53 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 49MBn42kWwz42rV X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-5.11 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[111.161.243.23.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-2.81)[ip: (-9.29), ipnet: 174.136.96.0/20(-4.27), asn: 25795(-0.45), country: US(-0.05)]; FREEMAIL_TO(0.00)[fastmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 22:10:01 -0000 On 5/11/20 4:21 PM, Pete Wright wrote: > > > On 5/11/20 3:28 PM, Yuri Pankov wrote: >> Pete Wright wrote: >>> hello, >>> i have a lenovo thinkpad P43s that exhibits lockups under CURRENT >>> but behaves fine when running STABLE.  i've tried to find a fully >>> reproducible situation to get this system to lockup but haven't >>> found anything yet.  i am starting to suspect that the changes >>> implemented in this review may be the issue though: >>> >>> https://reviews.freebsd.org/D23728 >>> >>> my reasoning is that i've observed issues when: >>> - removing AC power from the laptop, or inserting AC power >>> - when the system display has gone to sleep >>> - randomly hanging during boot with this as last line: >>> battery0: battery enitialization start >>> >>> unfortunately while the above seem to be cases where this has >>> happened i haven't been able to %100 reproduce yet. >>> >>> so my first question is - would it be possible to just revert the >>> changes in that diff, or has too much time gone past to just back >>> out that single change.  alternatively, is there any debugging >>> information i can get on my end that might help figure out what the >>> root cause is? >> >> Not really what you are asking, but it's possible to disable ACPI >> subdevices, so you could check if disabling cmbat completely helps >> and it's indeed the suspect: >> >> debug.acpi.disabled="cmbat" > > Thanks Yuri, > So I was able to boot my system once via batter with this set, but > unfortunately it crashed after I tried to suspend/resume. Realizing > that was a bit optimistic I attempted to reboot the system and wasn't > able to get it to fully boot after several attempts. > > I believe what the next step at this point is checkout the code right > before this commit and see if I can get it to successfully boot.  I'll > report back if I find anything after that test. > To follow-up on this I believe the updates in the above review may be the culprit.  What I have done is built a memstick.img set to the commit right before the changes in D23728 were merged.  running this image I can boot my system, disconnect and reconnect AC power without any issues. i then booted from a memstick using the latest snapshot of current. i can disconnect AC power without issues, but reconnecting hangs the system immediately. i've tested this a couple times and it seems pretty reproducible, not sure what the best next step would be though.  would someone here be willing to help me debug this, or would it be best to file a PR along with a dmesg and output from acpiconf? cheers! -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA