From nobody Mon Aug 7 22:45:44 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RKWcm5xGpz4mSvq; Mon, 7 Aug 2023 22:45:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RKWcm5Qm2z4PB8; Mon, 7 Aug 2023 22:45:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691448344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SGYS/s5ATbken+6Hle0AvYzfpYcY67gx81nVeSkHOBE=; b=SkKTNNdhGoyS4zC6CfnIzEX1SZjVxpx+gEGRDsQn9JMBW7Xe6LXED3bHFSmnrOkdrXE2Qa zC7W++FJtg5P420zdEmxGbNrB6mChCpAg8u8Ny22uSKFOGwhPC3OIfJmlEvjHriphNk9fX vv2cvEg9SOuyce8pF+xq56qZHqpyRXF6xqKJ4AQ767FGJAKsOE0Q2xpXZtdggjKGo7bgrn 0t+VvI0/f8s0pwJKiKvl+Dljzq4U4sG3bmrs7eDgs4HfElgT2e8SkVywRLLnN58S5KRnOr DRSMyuiaU6N9BkeB+Od24wuSgHS/yExWju/IlXm5JN4TYhrZigo4/6Z8YKElKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691448344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SGYS/s5ATbken+6Hle0AvYzfpYcY67gx81nVeSkHOBE=; b=UPo6DOn8JJzkMTk11oQFLNDfLMbkUIlMRu6OIfkZKZFuEN7T3KOJrO/JbzF2HrrR0LBF0G LxoIkmwDTAVQoI4ItAvadY962WD+cim1+KXiX4ELrVOHNp6qZ5iQ2pOb95GDox/aN1O+bj q+S2q2uIpGqyYu1wZ7xGa03lMkLfT4K/QoGXg68LRPMloGB+yRbLooC4+n4XuUStKy0b7b QTpcW+daJZkW2DXN4z9IEGk7RIn6KXOZSQ+31HmbxzGRc1cC0dnP3caqxX+w19DbKsO7Fr o5EE1r+Lfsib6e8Y9eFV1QIeepTXnqdkwgXVHdTD7ujM1qTSuVhGltO/jqpHnQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691448344; a=rsa-sha256; cv=none; b=GxjKEa0ebZgYcmyJQ0uEWXrx2MuyfE4WHs04A7R7874JVH64vjTMP03QqgyI3x0ZzG7MCy U+qWVLj0UlSwTsgI8tUMqnwG7BxM1ziyab/9mRg2zJ1ZW6+utl/iWaSMQ5lAI2GiYS1iC1 Z3HScihq1kqdqbXpvAYS+jFyeJcY3aP7gMruWmQv//3nSSEphnUExgMqZsN4ROrz1qx9Ky HL0BRSKozSCeZD1RvVDbMzSNztSiZUqclzSKF685Ln9ZO2Kjo5KHmGXsqv5qsr9a42F0zb AJ62yk3jqUGxozYdfgNwTm72CZxKtGnfRJmGWQDMGDuMvacaZNj8GQ+w47EK/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RKWcm4TWtz18jF; Mon, 7 Aug 2023 22:45:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 377MjiTi058717; Mon, 7 Aug 2023 22:45:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 377MjiBK058716; Mon, 7 Aug 2023 22:45:44 GMT (envelope-from git) Date: Mon, 7 Aug 2023 22:45:44 GMT Message-Id: <202308072245.377MjiBK058716@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 63b0c00eb043 - main - nvme: Update comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 63b0c00eb043cf8cfabeb63528eda3190608a805 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=63b0c00eb043cf8cfabeb63528eda3190608a805 commit 63b0c00eb043cf8cfabeb63528eda3190608a805 Author: Warner Losh AuthorDate: 2023-08-07 22:36:25 +0000 Commit: Warner Losh CommitDate: 2023-08-07 22:44:31 +0000 nvme: Update comment Fix comment to note we should grab additional data from the error log page, but don't currently (it's inclear if we should do that here and other places in nvd that want it, or if we should let nvd / the nda periph make the request). Sponsored by: Netflix Reviewed by: chuck, mav, jhb Differential Revision: https://reviews.freebsd.org/D41315 --- sys/dev/nvme/nvme_sim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_sim.c b/sys/dev/nvme/nvme_sim.c index ad6783adf181..7478f70013e6 100644 --- a/sys/dev/nvme/nvme_sim.c +++ b/sys/dev/nvme/nvme_sim.c @@ -69,7 +69,9 @@ nvme_sim_nvmeio_done(void *ccb_arg, const struct nvme_completion *cpl) /* * Let the periph know the completion, and let it sort out what - * it means. Make our best guess, though for the status code. + * it means. Report an error or success based on SC and SCT. + * We do not try to fetch additional data from the error log, + * though maybe we should in the future. */ memcpy(&ccb->nvmeio.cpl, cpl, sizeof(*cpl)); ccb->ccb_h.status &= ~CAM_SIM_QUEUED;