Date: Mon, 7 Aug 2023 22:45:44 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 63b0c00eb043 - main - nvme: Update comment Message-ID: <202308072245.377MjiBK058716@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=63b0c00eb043cf8cfabeb63528eda3190608a805 commit 63b0c00eb043cf8cfabeb63528eda3190608a805 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-08-07 22:36:25 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-08-07 22:44:31 +0000 nvme: Update comment Fix comment to note we should grab additional data from the error log page, but don't currently (it's inclear if we should do that here and other places in nvd that want it, or if we should let nvd / the nda periph make the request). Sponsored by: Netflix Reviewed by: chuck, mav, jhb Differential Revision: https://reviews.freebsd.org/D41315 --- sys/dev/nvme/nvme_sim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_sim.c b/sys/dev/nvme/nvme_sim.c index ad6783adf181..7478f70013e6 100644 --- a/sys/dev/nvme/nvme_sim.c +++ b/sys/dev/nvme/nvme_sim.c @@ -69,7 +69,9 @@ nvme_sim_nvmeio_done(void *ccb_arg, const struct nvme_completion *cpl) /* * Let the periph know the completion, and let it sort out what - * it means. Make our best guess, though for the status code. + * it means. Report an error or success based on SC and SCT. + * We do not try to fetch additional data from the error log, + * though maybe we should in the future. */ memcpy(&ccb->nvmeio.cpl, cpl, sizeof(*cpl)); ccb->ccb_h.status &= ~CAM_SIM_QUEUED;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308072245.377MjiBK058716>