From owner-cvs-src@FreeBSD.ORG  Wed Mar 26 19:56:48 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2706537B404; Wed, 26 Mar 2003 19:56:48 -0800 (PST)
Received: from HAL9000.homeunix.com (12-233-57-131.client.attbi.com
	[12.233.57.131])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 55B7D43F75; Wed, 26 Mar 2003 19:56:47 -0800 (PST)
	(envelope-from das@FreeBSD.org)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.6/8.12.5) with ESMTP id h2R3ujah014238;
	Wed, 26 Mar 2003 19:56:45 -0800 (PST)
	(envelope-from das@FreeBSD.org)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.6/8.12.5/Submit) id h2R3uiD2014237;
	Wed, 26 Mar 2003 19:56:44 -0800 (PST)
	(envelope-from das@FreeBSD.org)
Date: Wed, 26 Mar 2003 19:56:44 -0800
From: David Schultz <das@FreeBSD.org>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Message-ID: <20030327035644.GA14168@HAL9000.homeunix.com>
Mail-Followup-To: "Andrey A. Chernov" <ache@nagual.pp.ru>,
	src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200303192025.h2JKPjNr000550@repoman.freebsd.org>
	<20030320050712.GA48184@nagual.pp.ru>
	<20030320054502.GA4308@HAL9000.homeunix.com>
	<20030326151410.GA20472@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030326151410.GA20472@nagual.pp.ru>
X-Spam-Status: No, hits=-9.8 required=5.0
	tests=AWL,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,
	      REPLY_WITH_QUOTES
	autolearn=ham	version=2.50
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp)
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2003 03:56:51 -0000

Thus spake Andrey A. Chernov <ache@nagual.pp.ru>:
> On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote:
> > Do
> > you see anything else I should bug the vendor about while I'm at
> > it?  
> 
> With nowdays variant there is error in gethex.c:
> 
> CONST unsigned char *decpt, *s0, *s, *s1;
> ...
> char decimalpoint = *localeconv()->decimal_point;
> ...
> if (*s == decimalpoint) {
>        ^^^ It fails, if decimal point is in upper half of code table, i.e.
>        negative char.
>        
> Obvious fix:
> unsigned char decimalpoint ...

I wasn't aware that there existed locales that used anything other
than a decimal point or comma.  In any case, I've let the vendor know.