From owner-cvs-all@FreeBSD.ORG Tue Nov 28 12:58:19 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2F58716A40F; Tue, 28 Nov 2006 12:58:19 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id F320143CFA; Tue, 28 Nov 2006 12:46:34 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kASCk3Qu070997; Tue, 28 Nov 2006 12:46:03 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kASCk3uW070996; Tue, 28 Nov 2006 12:46:03 GMT (envelope-from ru) Message-Id: <200611281246.kASCk3uW070996@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 28 Nov 2006 12:46:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys vmmeter.h src/release/picobsd/tinyware/vm vm.c src/sbin/sysctl sysctl.c src/usr.bin/systat vmstat.c src/usr.bin/vmstat vmstat.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2006 12:58:19 -0000 ru 2006-11-28 12:46:02 UTC FreeBSD src repository Modified files: sys/sys vmmeter.h release/picobsd/tinyware/vm vm.c sbin/sysctl sysctl.c usr.bin/systat vmstat.c usr.bin/vmstat vmstat.c Log: - Revert signedness type changes to "struct vmtotal"; by making them unsigned I made the possible overflows hard to detect, and it only saved 1 bit which isn't principal, even less now that the underlying issue with the total of virtual memory has been fixed. (For the record, it will overflow with >=2T of VM total, with 32-bit ints used to keep counters in pages.) - While here, fix printing of other "struct vmtotal" members such as t_rq, t_dw, t_pw, and t_sw as they are also signed. Reviewed by: bde MFC after: 3 days Revision Changes Path 1.10 +8 -12 src/release/picobsd/tinyware/vm/vm.c 1.80 +11 -15 src/sbin/sysctl/sysctl.c 1.28 +14 -14 src/sys/sys/vmmeter.h 1.83 +19 -86 src/usr.bin/systat/vmstat.c 1.97 +3 -4 src/usr.bin/vmstat/vmstat.c