From owner-svn-src-all@FreeBSD.ORG Wed Feb 20 19:05:32 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8F9627B8 for ; Wed, 20 Feb 2013 19:05:32 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-la0-x234.google.com (la-in-x0234.1e100.net [IPv6:2a00:1450:4010:c03::234]) by mx1.freebsd.org (Postfix) with ESMTP id 1DCA0CFF for ; Wed, 20 Feb 2013 19:05:31 +0000 (UTC) Received: by mail-la0-f52.google.com with SMTP id fs12so7928013lab.39 for ; Wed, 20 Feb 2013 11:05:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=caZ8lbzXS67ogxijCDwrDd8reM1TOI6bgyCXy9A/upk=; b=jRfvGrJjpT4+p0qGNUS4ECFLw9H1TvAt2QmXo7f7oWlUBa5mYB/QDaVBRRqFg1bwT8 21VkOrqzBOb+4MjFRT6IVhdXH6ZsAKA1sLf6A8GAuJn7X8ABvIImgGW2vUzFZ8XeeROy 87akgTu93WOMhdA9OjG1CIJ9iTfMfraEDFfz0MQG7e/9Kgy5g3Pq/2dCeFP2lBMa9eWm cwmeH3CQqBWUt+WBBrmHpNO70ac73yWVVjtS8vwH345o9WPzE0F1qKmeETpnTHDgLKax lCpDfW/G1GCpKfaBenQdCKpLZCPa176A7JX8UbbFU7gHBfvGW7s4gxsqTS+3vKfJONUB xQlg== X-Received: by 10.112.17.108 with SMTP id n12mr8774420lbd.21.1361387130794; Wed, 20 Feb 2013 11:05:30 -0800 (PST) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.152.133.196 with HTTP; Wed, 20 Feb 2013 11:05:10 -0800 (PST) In-Reply-To: <86ip5mbyoj.fsf@ds4.des.no> References: <201302201259.r1KCxMUZ076597@svn.freebsd.org> <86ip5mbyoj.fsf@ds4.des.no> From: Juli Mallett Date: Wed, 20 Feb 2013 11:05:10 -0800 X-Google-Sender-Auth: Kk-HXhIDOGRZP9C1NHFQa3HWsFs Message-ID: Subject: Re: svn commit: r247035 - head/sys/dev/ixgbe To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQm6vVfJGT4H6R/WbCWEBZHN7uVZOY2xCMDEAdXo0BkrO41VJ5hKwa3LgMSu3rOYEM9aesDz Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jack Vogel X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2013 19:05:32 -0000 On Wed, Feb 20, 2013 at 10:57 AM, Dag-Erling Sm=C3=B8rgrav wro= te: > Jack Vogel writes: >> OK, this change must be backed out. This was not run past me, and this >> is a shared code file, that means its code that we license in both >> GPL, BSD, and closed source licensing, and thus we CANNOT accept >> changes without special handling. Further, I do not author this code, >> its done by another team internally, and I simply accept it as a >> component. > > I think you're confused. I did not commit this to Intel's code > repository. I committed it to FreeBSD's code repository as a precursor > to a slightly more extensive patch which I intend to commit once I've > tested it more thoroughly. Please don't. Many others have accepted/respected Jack's maintainership by letting him keep control of the in-tree driver as much as is possible, particularly outside of ixgbe.c. I would love to have committed my code to handle 1G SFPs quite some time ago, but it makes at least a little sense to me that Jack handles the merges and testing and whatnot and doesn't need the additional work of maintaining FreeBSD additions he can't test. In general, the benefit of having the Intel drivers updated regularly by someone who has done extensive testing and who has the backing of Intel has outweighed the cost of deferring to Intel and Jack about what can go into the drivers. If your changes are so compelling, I would have expected them to have appeared at least on a major public mailing list, rather than committed at a whim to a driver which has a clear and obvious maintainer. If we really do have a lot of wonderful changes that are stalled by Jack's maintainership, provide a second driver in-tree and maintain it, which has all the go-faster/better/stronger stripes. It's not just Jack that unexpected changes to these critical drivers make things harder for. There's Luigi, Ryan Stone, John Baldwin, myself and others, who maintain extensions to the Intel drivers in-tree and/or privately. Thanks, Juli.