From owner-p4-projects@FreeBSD.ORG Sat Jun 12 03:31:31 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 36B371065672; Sat, 12 Jun 2010 03:31:31 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3557106566B for ; Sat, 12 Jun 2010 03:31:30 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id A7D968FC12 for ; Sat, 12 Jun 2010 03:31:30 +0000 (UTC) Received: by iwn7 with SMTP id 7so2388214iwn.13 for ; Fri, 11 Jun 2010 20:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=5W6arGotsxtMYTILKmJGb987xNJo2xpX7sg5lwT83UU=; b=JaN1cUo61K9R8fNvgFU10KDVsErpvCSW/wDgSNWVEpDiSY++bvieXhW3aB27GfbFoh n7tVpj4++4jRHSEWTL+NRZ2X6HmtthgEHOTLzrmhhPNxLO5Nfmm+rTMAX4wE1+oYT9+d lAIhoac33mqKI0doPDca6eH36EDjhqRhzS6Jo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Ms4aHhgFJxMjg7nZSiRcSowMCOQG71xNb/aZqf1Vm3qz2ACeaxUWi5I2kh14ifGZdS ra4ise1XgKPB20OjrQXrLrlAZFahyUvH1d0w50V+G1N99VUYGiPZCikKb1aZe+IEmAAc w++S7dVBtC6CJDGwpEgAy9aVcGb7crQlZz+nc= MIME-Version: 1.0 Received: by 10.231.60.5 with SMTP id n5mr532569ibh.162.1276313489650; Fri, 11 Jun 2010 20:31:29 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.231.69.19 with HTTP; Fri, 11 Jun 2010 20:31:29 -0700 (PDT) In-Reply-To: <201006112217.o5BMHtaQ086056@repoman.freebsd.org> References: <201006112217.o5BMHtaQ086056@repoman.freebsd.org> Date: Fri, 11 Jun 2010 20:31:29 -0700 X-Google-Sender-Auth: 7Isb_slSIyHOTgx4b_-fJSTrbes Message-ID: From: Garrett Cooper To: Alexandre Fiveg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 179499 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 03:31:31 -0000 On Fri, Jun 11, 2010 at 3:17 PM, Alexandre Fiveg wrote= : > http://p4web.freebsd.org/@@179499?ac=3D10 > > Change 179499 by afiveg@cottonmouth on 2010/06/11 22:16:54 > > =A0 =A0 =A0 =A0em/Makefile cosmetic fix > > Affected files ... > > .. //depot/projects/soc2010/ringmap/current/sys/modules/em/Makefile#5 edi= t > > Differences ... > > =3D=3D=3D=3D //depot/projects/soc2010/ringmap/current/sys/modules/em/Make= file#5 (text+ko) =3D=3D=3D=3D > > @@ -1,5 +1,5 @@ > =A0# $FreeBSD: src/sys/modules/em/Makefile,v 1.16 2010/03/29 23:36:34 jfv= Exp $ > -.PATH: =A0${.CURDIR}/../../dev/e1000 > +.PATH: =A0${.CURDIR}/../../dev/e1000 : ${.CURDIR}/../../net The colon is a syntax error, isn't it? > =A0.if defined(KERNEL_RINGMAP) > =A0KMOD =A0 =3D if_ringmap > @@ -13,7 +13,7 @@ > > =A0.if defined(KERNEL_RINGMAP) > =A0CFLAGS +=3D -D__RINGMAP__ -D__E1000_RINGMAP__ > -SRCS =A0 =A0 =A0 =A0 =A0 +=3D ${.CURDIR}/../../net/ringmap.c > +SRCS =A0 =A0 =A0 =A0 =A0 +=3D ringmap.c > =A0.endif > > =A0CORE_SRC =3D if_em.c e1000_osdep.c Thanks, -Garrett