From owner-cvs-all@FreeBSD.ORG  Wed Sep  8 13:07:50 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CB1DC16A4CE; Wed,  8 Sep 2004 13:07:50 +0000 (GMT)
Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net
	[69.140.212.7])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0BE6043D46; Wed,  8 Sep 2004 13:07:50 +0000 (GMT)
	(envelope-from green@green.homeunix.org)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i88D7fGn076302;
	Wed, 8 Sep 2004 09:07:46 -0400 (EDT)
	(envelope-from green@green.homeunix.org)
Received: (from green@localhost)
	by green.homeunix.org (8.13.1/8.13.1/Submit) id i88D7foE076301;
	Wed, 8 Sep 2004 09:07:41 -0400 (EDT)
	(envelope-from green)
Date: Wed, 8 Sep 2004 09:07:41 -0400
From: Brian Fundakowski Feldman <green@FreeBSD.ORG>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20040908130741.GC928@green.homeunix.org>
References: <200409080713.i887Dd54058789@repoman.freebsd.org>
	<20040908.012031.93204322.imp@bsdimp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040908.012031.93204322.imp@bsdimp.com>
User-Agent: Mutt/1.5.6i
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/usb ugen.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Sep 2004 13:07:51 -0000

On Wed, Sep 08, 2004 at 01:20:31AM -0600, M. Warner Losh wrote:
> In message: <200409080713.i887Dd54058789@repoman.freebsd.org>
>             Warner Losh <imp@FreeBSD.org> writes:
> : imp         2004-09-08 07:13:39 UTC
> : 
> :   FreeBSD src repository
> : 
> :   Modified files:
> :     sys/dev/usb          ugen.c 
> :   Log:
> :   Back out 1.88.
>              1.87 I mean.
> :   The reference counts are there to block detach until the sleepers in
> :   read/write/ioctl have gotten out, not to prevent the open device from
> :   going away.  Restore the old behavior so that we have a chance to wake
> :   up sleepers when the usb device goes away, so they can properly return
> :   EIO back to the caller when this happens.
> :   
> :   Otherwise, we have a guarnateed panic waiting to happen when a device
> :   detaches with an active read channel.
> :   
> :   This should be merged to 5 asap.

Now I'll get guaranteed panics using both my Palm and any CardBus hardware.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\