From owner-svn-ports-all@freebsd.org  Mon Dec 12 17:10:09 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5828CC73C80
 for <svn-ports-all@mailman.ysv.freebsd.org>;
 Mon, 12 Dec 2016 17:10:09 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.com (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 34BEE1EC4;
 Mon, 12 Dec 2016 17:10:09 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from [127.0.0.1] (ip72-204-83-236.fv.ks.cox.net [72.204.83.236])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.com (Postfix) with ESMTP id A4FD943C04;
 Mon, 12 Dec 2016 11:09:01 -0600 (CST)
Subject: Re: svn commit: r428233 - head/Mk/Uses [kmod.mk]
Reply-To: marino@freebsd.org, marino@freebsd.org
References: <201612091847.uB9Il9uR007592@repo.freebsd.org>
 <5cdc9a0f-4b88-ca81-7c0c-f5e4fc2f8a93@marino.st>
To: Rene Ladan <rene@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, Gleb Smirnoff <glebius@FreeBSD.org>
From: John Marino <freebsd.contact@marino.st>
Message-ID: <f6b1e2c2-57f6-3e13-47e5-efb8b5167761@marino.st>
Date: Mon, 12 Dec 2016 11:10:04 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <5cdc9a0f-4b88-ca81-7c0c-f5e4fc2f8a93@marino.st>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Antivirus: avast! (VPS 161212-0, 12/12/2016), Outbound message
X-Antivirus-Status: Clean
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 17:10:09 -0000

On 12/10/2016 10:42, John Marino wrote:
> On 12/9/2016 12:47, Rene Ladan wrote:
>> Author: rene
>> Date: Fri Dec  9 18:47:09 2016
>> New Revision: 428233
>> URL: https://svnweb.freebsd.org/changeset/ports/428233
>>
>> Log:
>>   Uses/kmod.mk: add support for debug versions of kernel modules.
>>
>>   Submitted by:    glebius via private mail
>>
>> Modified:
>>   head/Mk/Uses/kmod.mk
>>
>> Modified: head/Mk/Uses/kmod.mk
>> ==============================================================================
>>
>> --- head/Mk/Uses/kmod.mk    Fri Dec  9 17:50:43 2016    (r428232)
>> +++ head/Mk/Uses/kmod.mk    Fri Dec  9 18:47:09 2016    (r428233)
>> @@ -34,13 +34,19 @@ MAKE_ENV+=    KMODDIR="${KMODDIR}" SYSDIR="
>>  PLIST_FILES+=    "@kld ${KMODDIR}"
>>
>>  STRIP_CMD+=    --strip-debug # do not strip kernel symbols
>> +KERN_DEBUGDIR?=    ${DEBUGDIR}
>>  .endif
>>
>>  .if defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_KMOD_POST_MK)
>>  _INCLUDE_USES_KMOD_POST_MK=    yes
>>
>>  _USES_install+=    290:${STAGEDIR}${KMODDIR}
>> +_USES_install+=    291:${STAGEDIR}${KERN_DEBUGDIR}${KMODDIR}
>> +
>>  ${STAGEDIR}${KMODDIR}:
>>      @${MKDIR} ${.TARGET}
>>
>> +${STAGEDIR}${KERN_DEBUGDIR}${KMODDIR}:
>> +    @${MKDIR} ${.TARGET}
>> +
>>  .endif
>>
>
>
> After this commit, I am seeing:
> make: "/xports/Mk/Uses/kmod.mk" line 50: warning: duplicate script for
> target "/construction/x11-drivers/drm-kmod/stage/boot/modules" ignored
> make: "/xports/Mk/Uses/kmod.mk" line 47: warning: using previous script
> for "/construction/x11-drivers/drm-kmod/stage/boot/modules" defined here
>
> The cause is that if KERN_DEBUGDIR is not defined, the targets ending in
> ${KMODDIR} are identical.  There needs to be a guard checking for the
> definition of KERN_DEBUGDIR.
>
> Thanks,
> John

Resending -- I was having DNS issues that caused my mail not to be 
delivered to @FreeBSD addresses for a while.

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus