From owner-freebsd-ports@FreeBSD.ORG Fri Apr 13 22:32:21 2007 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E1A2216A404; Fri, 13 Apr 2007 22:32:21 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.131.111.2]) by mx1.freebsd.org (Postfix) with ESMTP id 9D9C113C48A; Fri, 13 Apr 2007 22:32:21 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from acrux.dbai.tuwien.ac.at (acrux [128.131.111.60]) by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id 6FEBA1379A; Sat, 14 Apr 2007 00:32:20 +0200 (CEST) Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203) id D2E4A1A7C9; Sat, 14 Apr 2007 00:32:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id C2F431A7C7; Sat, 14 Apr 2007 00:32:26 +0200 (CEST) Date: Sat, 14 Apr 2007 00:32:26 +0200 (CEST) From: Gerald Pfeifer To: Rong-en Fan , Pav Lucistnik , Maho NAKATA In-Reply-To: <1176486909.11148.0.camel@ikaros.oook.cz> Message-ID: References: <461E1CC8.7090606@adestra.com> <200704121918.21307.andy@athame.co.uk> <6eb82e0704121003n30a209c5y25d8f64ba6b43eeb@mail.gmail.com> <6eb82e0704130439w40d38a80h69d059b26c8189d3@mail.gmail.com> <1176486909.11148.0.camel@ikaros.oook.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andy Fawcett , freebsd-ports@freebsd.org Subject: Re: Generating INDEX X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2007 22:32:22 -0000 On Fri, 13 Apr 2007, Rong-en Fan wrote: > No, the patch won't work. According to > http://www.freebsd.org/gnome/docs/porting.html, > the right way is always define WANT_GNOME which won't pull > any gnome dependencies unless USE_GNOME is used. > > I think after USE_PERL5_BUILD line, add > > WANT_GNOME=yes > > and use += for USE_GNOME after bsd.port.pre.mk Thanks. This matches my reading of http://www.freebsd.org/gnome/docs/porting.html as well, so I committed the patch at the end of this message to hopefully address the breakage. On Fri, 13 Apr 2007, Pav Lucistnik wrote: >> I think after USE_PERL5_BUILD line, add >> >> WANT_GNOME=yes >> >> and use += for USE_GNOME after bsd.port.pre.mk > The usual workaround is > > USE_GNOME= # empty > > .include > > USE_GNOME+= foo bar baz What Rong-en proposed matches my reading of our GNOME porting documentation, and according to my reading of bsd.port.mk your proposal is just another way of achieving the same result. Is this correct? What worries me more is that the same documentation also has: Note: You cannot add extra default USE_GNOME components after the .include . That is, the following is wrong : .include .if ${HAVE_GNOME:Mgnomelibs}!="" USE_GNOME+= libgnome .else USE_GNOME+= gtk12 # WRONG! .endif and lang/gcc41 has the following right now after .include : USE_GNOME= gtk20 libartlgpl2 Should we move the USE_GNOME=gtk20 part into lang/gcc41-withgcjawt and only keep USE_GNOME+=libartlgpl2 at this point in lang/gcc41 or is the current use okay in this specific setting? Gerald PS: For now I committed the patch below which ought to be correct in any case. I won't be able to be online too much over the weekend, so if any of you please be more than welcome to apply any followup patch as needed if you are confident it is the right thing to do. Index: Makefile =================================================================== RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v retrieving revision 1.318 diff -u -3 -p -r1.318 Makefile --- Makefile 10 Apr 2007 05:24:27 -0000 1.318 +++ Makefile 13 Apr 2007 22:06:51 -0000 @@ -34,6 +34,7 @@ USE_BZIP2= yes USE_GMAKE= yes USE_ICONV= yes USE_PERL5_BUILD=yes +WANT_GNOME= yes PATCH_WRKSRC= ${SRCDIR} CONFIGURE_SCRIPT= ../${SRCDIR:C/${WRKDIR}//}/configure