From owner-svn-src-all@freebsd.org Mon May 23 18:43:31 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89836B4727C; Mon, 23 May 2016 18:43:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B14B1DB7; Mon, 23 May 2016 18:43:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 493A8B95B; Mon, 23 May 2016 14:43:30 -0400 (EDT) From: John Baldwin To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300372 - in head/sys: kern sys Date: Mon, 23 May 2016 11:43:27 -0700 Message-ID: <8562415.t0UfIz1aLk@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201605211451.u4LEpopu074806@repo.freebsd.org> References: <201605211451.u4LEpopu074806@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 23 May 2016 14:43:30 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 18:43:31 -0000 On Saturday, May 21, 2016 02:51:50 PM Andriy Gapon wrote: > Author: avg > Date: Sat May 21 14:51:49 2016 > New Revision: 300372 > URL: https://svnweb.freebsd.org/changeset/base/300372 > > Log: > fix loss of taskqueue wakeups (introduced in r300113) > > Submitted by: kmacy > Tested by: dchagin > > Modified: head/sys/sys/taskqueue.h > ============================================================================== > --- head/sys/sys/taskqueue.h Sat May 21 11:40:41 2016 (r300371) > +++ head/sys/sys/taskqueue.h Sat May 21 14:51:49 2016 (r300372) > @@ -114,7 +113,6 @@ void taskqueue_thread_enqueue(void *cont > */ > #define TASK_INIT(task, priority, func, context) do { \ > (task)->ta_pending = 0; \ > - (task)->ta_flags = 0; \ > (task)->ta_priority = (priority); \ > (task)->ta_func = (func); \ > (task)->ta_context = (context); \ > @@ -224,7 +222,6 @@ int taskqgroup_adjust(struct taskqgroup > > #define GTASK_INIT(task, priority, func, context) do { \ > (task)->ta_pending = 0; \ > - (task)->ta_flags = TASK_SKIP_WAKEUP; \ > (task)->ta_priority = (priority); \ > (task)->ta_func = (func); \ > (task)->ta_context = (context); \ Do we still need GTASK_INIT() now or can relevant tasks now use TASK_INIT instead and GTASK_INIT be retired? -- John Baldwin