From owner-freebsd-emulation@FreeBSD.ORG Sun Nov 25 10:53:11 2007 Return-Path: Delivered-To: emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E967216A418; Sun, 25 Nov 2007 10:53:11 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id A215A13C455; Sun, 25 Nov 2007 10:53:11 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id DE99566A42F; Sun, 25 Nov 2007 11:52:59 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4FfQCMzL-8M3; Sun, 25 Nov 2007 11:52:58 +0100 (CET) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id B99E666A420; Sun, 25 Nov 2007 11:52:58 +0100 (CET) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id lAPAqwsH090228; Sun, 25 Nov 2007 11:52:58 +0100 (CET) (envelope-from rdivacky) Date: Sun, 25 Nov 2007 11:52:58 +0100 From: Roman Divacky To: John Hein Message-ID: <20071125105258.GA89946@freebsd.org> References: <20071124221946.GA74651@freebsd.org> <18248.50538.142360.921846@gromit.timing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18248.50538.142360.921846@gromit.timing.com> User-Agent: Mutt/1.4.2.3i Cc: emulation@freebsd.org, des@freebsd.org Subject: Re: compat/linprocfs X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2007 10:53:12 -0000 On Sat, Nov 24, 2007 at 05:44:26PM -0700, John Hein wrote: > Roman Divacky wrote at 23:19 +0100 on Nov 24, 2007: > > in > > compat/linprocfs/linprocfs.c:linprocfs_doprocmaps() there's > > > > unsigned int last_timestamp; > > > > variable declaration, this variable is used only once in this function: > > > > if (last_timestamp + 1 != map->timestamp) { > > > > ie. the map->timestamp is compared to some stack garbage + 1. this does not > > seem to be correct, the last_timestamp must be set somewhere.. > > > > comments? > > It is set 6 lines earlier... > > last_timestamp = map->timestamp; > vm_map_unlock_read(map); > error = uiomove(mebuffer, len, uio); > vm_map_lock_read(map); > if (error) > break; > if (last_timestamp + 1 != map->timestamp) { sorry, mea culpa.. I have some local modifications :( I apology for the noise