From owner-freebsd-current  Tue Feb 22 18:54:32 2000
Delivered-To: freebsd-current@freebsd.org
Received: from filk.iinet.net.au (filk.iinet.net.au [203.59.24.235])
	by hub.freebsd.org (Postfix) with ESMTP
	id F3BBA37B882; Tue, 22 Feb 2000 18:54:24 -0800 (PST)
	(envelope-from julian@elischer.org)
Received: from jules.elischer.org (reggae-20-179.nv.iinet.net.au [203.59.85.179])
	by filk.iinet.net.au (8.8.4/8.8.5) with SMTP id KAA28134;
	Wed, 23 Feb 2000 10:54:06 +0800
Message-ID: <38B34BBA.41C67EA6@elischer.org>
Date: Tue, 22 Feb 2000 18:53:46 -0800
From: Julian Elischer <julian@elischer.org>
X-Mailer: Mozilla 3.04Gold (X11; I; FreeBSD 4.0-CURRENT i386)
MIME-Version: 1.0
To: Archie Cobbs <archie@whistle.com>
Cc: Yevmenkin Maksim N CSCIO <myevmenkin@att.com>,
	freebsd-current@freebsd.org, freebsd-hackers@freebsd.org
Subject: Re: NETGRAPH patches (proposal)
References: <200002222225.OAA42237@bubba.whistle.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Archie Cobbs wrote:
> 
> Yevmenkin, Maksim N, CSCIO writes:
> > > > Here is the description. ng_ether node has two hooks ``divert'' and
> > > > ``orphan''.
> > > > It is possible to connect to the one of the hooks and
> > > intercept row Ethernet
> > > > frames. But there is no clean way to intercept frame, do
> > > something and
> > > > return it back to kernel.
> > > >
> > > > This patch provides additional hook ``divertin'' (mmm...
> > > name is not good,
> > > > i think) for each ng_ether node.
> > > >
> > > > Implementation issues
> > > >
> > > > This will not work for ``orphan'' frames. Since kernel
> > > drops it anyway, i
> > > > decided to leave it as it is. But is is possible to
> > > intercept ``orphan''
> > > > packets, change it, and write back to ``divertin''.
> > >
> > > The "divertin" hook is a useful idea.. after 4.0-REL we can check
> > > something in based on your patches...
> > >
> >
> > ok. i just have a dumb question. what is the big deal with updating
> > ether_shost
> > in ethernet header in ngether_rcvdata. since we are passing raw ethernet
> > frame,
> > why should we update ether_shost?  wouldn't it be nice to make it optional?
> > just another control message?
> 
> I agree.. you should have to set the host address manually.
> 
> -Archie


It's because all packets sent by this node should have the node's
address. If you don't have it then PPPoE cannot send a packet "FROM"
thia node, as it has no idea of what this node's address is.

> 
> ___________________________________________________________________________
> Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-hackers" in the body of the message

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000
---> X_.---._/  presently in:  Perth
            v


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message