From owner-svn-src-head@freebsd.org Tue Dec 5 21:25:45 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10116E82AFF; Tue, 5 Dec 2017 21:25:45 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x229.google.com (mail-lf0-x229.google.com [IPv6:2a00:1450:4010:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 871B1712F5; Tue, 5 Dec 2017 21:25:44 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x229.google.com with SMTP id i2so1930510lfe.9; Tue, 05 Dec 2017 13:25:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0oe+EeXPZ2QpRoppWriDysRNRcOgz5AQpSd3gYCOSSg=; b=PXoGyz7+AxSsBHSJbonJWYsRNYF44OTTMyLO2dk0HTtVgpJ5lNw3DVTpUJwLzyn1Oe mHx7Dl6P8riFaKLqn9lWghNUPIW0magx+bN/4oCLoaVp8Zasgf9AxqtJ3LcyAuNbR+AD K3cH7f8h8D4k+fKrzYrPeYwskv5hPoM9z1Xyl9o+wWqf7JqX5F9a6PvfOf9zhy2RGJKo 10VTtkMxvYr++dL8T4fv2XbTR5vAKzmAAR2IFlIHpmR0naKayoIsDso08WAlvMtN5Dy4 vvGyqaPHm1JsY45wpspgEsqHcI1HkOb0VL+IunROI9bSvtrTaNSqZEdMVhW09PsBdRTT YAgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0oe+EeXPZ2QpRoppWriDysRNRcOgz5AQpSd3gYCOSSg=; b=KMHvz/AYsvp/1AtH0FhhebGFAP3vWToGIINAK2YKQh8nFlUmdPlq8N9TIbej1wW5wH oMuC3lxdIpnQzIIOkV6PBtMW/Ptv/hP5uM0XgEnDi9EIkRZRD1VIxlqssB+zv3bG16FD yUH+j+nNad5vOaA03XRO3uIOtADrCV2HLj5U+J+wc1KxiqqB1/7CJBOyVxCBbLYTZgOF 1FLCQqbITQ1v2+QAZR7P6s6zWkX9GefcBYc+PeyYu1H1uyFAxPYSEVld+KR4FvlkhEwa ez0RCx2Gn/PTMdFAhQYpXarqhS5HZF4FpbzbQNEf2t+XIwpcGAbDhHd+d9wnOS5ERTIC iSDQ== X-Gm-Message-State: AJaThX5r1/8xc/GyckyU2/c/z9uj6uenUnxYQBFwoboUR0g6FJ7OBteJ +Wei2VgGC7zuqpnLYCtAhDcx7HLvOl/+4jnbpao= X-Google-Smtp-Source: AGs4zMYUlMrZszHqDNoZyrJJDiUP2ynzR9Zw8AeHplyGcrniD/zzYyJpBU4KKb+e1K1pSOyLdD/OohLymBvyEvIWog8= X-Received: by 10.46.20.4 with SMTP id u4mr11511007ljd.38.1512509142210; Tue, 05 Dec 2017 13:25:42 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.76.19 with HTTP; Tue, 5 Dec 2017 13:25:41 -0800 (PST) In-Reply-To: <201505051452.t45EqXXv027613@svn.freebsd.org> References: <201505051452.t45EqXXv027613@svn.freebsd.org> From: Alan Somers Date: Tue, 5 Dec 2017 14:25:41 -0700 X-Google-Sender-Auth: BuRAPCkH4JtRX5U5PdPZLOSAY9Y Message-ID: Subject: Re: svn commit: r282485 - head/lib/libc/gen To: Julian Elischer Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 21:25:45 -0000 On Tue, May 5, 2015 at 8:52 AM, Julian Elischer wrote: > Author: julian > Date: Tue May 5 14:52:33 2015 > New Revision: 282485 > URL: https://svnweb.freebsd.org/changeset/base/282485 > > Log: > Tweak seekdir, telldir and readdir so that when htere are deletes going > on, > as seek to teh last location saved will still work. This is needed for > Samba > to be able to correctly handle delete requests from windows. This does > not > completely fix seekdir when deletes are present but fixes the worst of > the > problems. The real solution must involve some changes to the API for eh > VFS > and getdirentries(2). > > Obtained from: Panzura inc > MFC after: 1 week > > Modified: > head/lib/libc/gen/directory.3 > head/lib/libc/gen/readdir.c > head/lib/libc/gen/rewinddir.c > head/lib/libc/gen/telldir.c > head/lib/libc/gen/telldir.h > Do you remember what the exact problem you had was? I'm trying to write a regression test for it, but I'm having trouble guessing what the bug was. And was _fixtelldir() related to the issue with deletes, or was that to fix a separate bug? -Alan